Author: Alexander Beregalov <a.beregalov@gmail.com> Use kzalloc rather than kmalloc followed by memset with 0. Found by coccinelle. Signed-off-by: Alexander Beregalov Signed-off-by: Greg Kroah-Hartman — drivers/staging/spectra/flash.c | 26 +++++++++—————– 1 file changed, 9 insertions(+), 17 deletions(-) diff –git a/drivers/staging/spectra/flash.c b/drivers/staging/spectra/flash.c index f11197b..a2f8200 100644 — a/drivers/staging/spectra/flash.c +++ b/drivers/staging/spectra/flash.c @@ -428,10 +428,9 @@ static int allocate_memory(void) DeviceInfo.wPageDataSize; …
Mar 09 2011
staging: brcm80211: optimize kmalloc to kzalloc
Author: Alexander Beregalov <a.beregalov@gmail.com> Use kzalloc rather than kmalloc followed by memset with 0. Found by coccinelle. Signed-off-by: Alexander Beregalov Signed-off-by: Greg Kroah-Hartman — drivers/staging/brcm80211/brcmfmac/dhd_linux.c | 4 +— drivers/staging/brcm80211/brcmfmac/dhd_sdio.c | 6 ++—- drivers/staging/brcm80211/brcmfmac/wl_iw.c | 9 +++—— drivers/staging/brcm80211/brcmsmac/wl_mac80211.c | 4 +— 4 files changed, 7 insertions(+), 16 deletions(-) diff –git a/drivers/staging/brcm80211/brcmfmac/dhd_linux.c b/drivers/staging/brcm80211/brcmfmac/dhd_linux.c index ab8e688..d473f64 100644 …
Mar 09 2011
staging: bcm: optimize kmalloc to kzalloc
Author: Alexander Beregalov <a.beregalov@gmail.com> Use kzalloc rather than kmalloc followed by memset with 0. Found by coccinelle. Signed-off-by: Alexander Beregalov Signed-off-by: Greg Kroah-Hartman — drivers/staging/bcm/Bcmchar.c | 4 +— drivers/staging/bcm/Misc.c | 6 ++—- 2 files changed, 3 insertions(+), 7 deletions(-) diff –git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c index 3d9055a..867dbf1 100644 — a/drivers/staging/bcm/Bcmchar.c +++ b/drivers/staging/bcm/Bcmchar.c @@ -19,12 +19,10 @@ …
Mar 08 2011
mwl8k: use kcalloc instead of kmalloc & memset
Author: Shan Wei <shanwei@cn.fujitsu.com> Use kcalloc or kzalloc rather than the combination of kmalloc and memset. Thanks coccicheck for detecting this. (http://coccinelle.lip6.fr/) Signed-off-by: Shan Wei Signed-off-by: John W. Linville — drivers/net/wireless/mwl8k.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-) diff –git a/drivers/net/wireless/mwl8k.c b/drivers/net/wireless/mwl8k.c index df5959f..3695227 100644 — a/drivers/net/wireless/mwl8k.c +++ b/drivers/net/wireless/mwl8k.c @@ -1056,13 …
Mar 07 2011
netfilter:ipvs: use kmemdup
Author: Shan Wei <shanwei@cn.fujitsu.com> The semantic patch that makes this output is available in scripts/coccinelle/api/memdup.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Shan Wei Signed-off-by: Simon Horman — net/netfilter/ipvs/ip_vs_pe_sip.c | 9 ++++—– net/netfilter/ipvs/ip_vs_sync.c | 3 +– 2 files changed, 5 insertions(+), 7 deletions(-) diff –git a/net/netfilter/ipvs/ip_vs_pe_sip.c b/net/netfilter/ipvs/ip_vs_pe_sip.c index 0d83bc0..13d607a 100644 — …
Feb 26 2011
watchdog: Convert release_resource to release_region/release_mem_region
Author: Julia Lawall <julia@diku.dk> Request_mem_region should be used with release_mem_region, not release_resource. In pnx4008_wdt.c, a missing clk_put is added as well. The semantic match that finds the first problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,E; @@ *x = request_mem_region(…) … when != release_mem_region(x) when != x = E * release_resource(x); // Signed-off-by: Julia …
Feb 26 2011
watchdog: s3c2410_wdt.c: Convert release_resource to release_region/release_mem_region
Author: Julia Lawall <julia@diku.dk> Request_mem_region should be used with release_mem_region, not release_resource. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,E; @@ *x = request_mem_region(…) … when != release_mem_region(x) when != x = E * release_resource(x); // Signed-off-by: Julia Lawall Signed-off-by: Wim Van Sebroeck Cc: stable — drivers/watchdog/s3c2410_wdt.c | …
Feb 21 2011
ARM: 6745/1: kprobes insn decoding fix
Author: Nicolas Pitre <nicolas.pitre@linaro.org> Marcin Slusarz says: > In arch/arm/kernel/kprobes-decode.c there’s a function > arm_kprobe_decode_insn which does: > > } else if ((insn & 0x0e000000) == 0x0c400000) { > … > > This is always false, so code below is dead. > I found this bug by coccinelle (http://coccinelle.lip6.fr/). Reported-by: Marcin Slusarz Signed-off-by: Nicolas Pitre …
Feb 20 2011
staging/et131x: fix et131x_rx_dma_disable halt_status usage
Author: Marcin Slusarz <marcin.slusarz@gmail.com> Commit 1bd751c1abc1029e8a0ae63ef4f19357c735a2a3 (« Staging: et131x: Clean up rxdma_csr ») changed csr from bitfield to u32, but failed to convert 2 uses of halt_status bit. It did: – if (csr.bits.halt_status != 1) + if ((csr & 0x00020000) != 1) which is wrong, because second version is always true. Fix it. This bug was found …
Feb 16 2011
hwrng: omap – Convert release_resource to release_region/release_mem_region
Author: Julia Lawall <julia@diku.dk> Request_region should be used with release_region, not release_resource. The local variable mem, storing the result of request_mem_region, is dropped and instead the pointer res is stored in the drvdata field of the platform device. This information is retrieved in omap_rng_remove to release the region. The drvdata field is not used elsewhere. …
