Author: Joe Perches <joe@perches.com> Unnecessary casts of void * clutter the code. These are the remainder casts after several specific patches to remove netdev_priv and dev_priv. Done via coccinelle script: $ cat cast_void_pointer.cocci @@ type T; T *pt; void *pv; @@ – pt = (T *)pv; + pt = pv; Signed-off-by: Joe Perches Acked-by: Paul …
Jun 11 2011
spi: Convert uses of struct resource * to resource_size(ptr)
Author: Joe Perches <joe@perches.com> Done via coccinelle scripts like: @@ struct resource *ptr; @@ – ptr->end – ptr->start + 1 + resource_size(ptr) and some grep and typing. Mostly uncompiled, no cross-compilers. Signed-off-by: Joe Perches Signed-off-by: Grant Likely — drivers/spi/spi-ath79.c | 2 +- drivers/spi/spi-omap2-mcspi.c | 10 +++++—– drivers/spi/spi-orion.c | 6 +++— drivers/spi/spi-ppc4xx.c | 2 +- drivers/spi/spi-tegra.c …
Jun 09 2011
treewide: Convert uses of struct resource to resource_size(ptr)
Author: Joe Perches <joe@perches.com> Several fixes as well where the +1 was missing. Done via coccinelle scripts like: @@ struct resource *ptr; @@ – ptr->end – ptr->start + 1 + resource_size(ptr) and some grep and typing. Mostly uncompiled, no cross-compilers. Signed-off-by: Joe Perches Signed-off-by: Jiri Kosina — arch/arm/common/scoop.c | 2 +- arch/arm/mach-at91/at91sam9261_devices.c | 2 +- …
Jun 08 2011
hwrng: nomadik – add missing clk_put
Author: Julia Lawall <julia@diku.dk> Jump to the end of the function for the clk_disable and clk_put rather than returning directly. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression e1,e2; statement S; @@ e1 = clk_get@p1(…); … when != e1 = e2 when != clk_put(e1) …
Jun 08 2011
hwrng: omap – add missing clk_put
Author: Julia Lawall <julia@diku.dk> Convert a return to a jump to an existing label that calls clk_put. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression e1,e2; statement S; @@ e1 = clk_get@p1(…); … when != e1 = e2 when != clk_put(e1) when any if …
Jun 07 2011
[CPUFREQ] s5pv210-cpufreq.c: Add missing clk_put
Author: Julia Lawall <julia@diku.dk> The successive calls to clk_get each call clk_put in the case of failure, but this is not done for subsequent error handling code. The calls to clk_get are moved to the end of the function, and appropriate gotos are added. A simplified version of the semantic match that finds this problem …
Jun 01 2011
drivers/net/can/flexcan.c: add missing clk_put
Author: Julia Lawall <julia@diku.dk> The failed_get label is used after the call to clk_get has succeeded, so it should be moved up above the call to clk_put. The failed_req labels doesn’t do anything different than failed_get, so delete it. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // …
Jun 01 2011
drivers/video/pxa168fb.c: add missing clk_put
Author: Julia Lawall <julia@diku.dk> Add a label for error-handling code in the case where only clk_get has succeeded. Rename the label failed to be consistent with the rest. A simplified version of the semantic match that finds the missing clk_put is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression e1,e2; statement S; @@ e1 = clk_get@p1(…); …
Jun 01 2011
drivers/video/imxfb.c: add missing clk_put
Author: Julia Lawall <julia@diku.dk> Reorder the labels at the end of the function to correspond to the order in which the resources are allocated. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression e1,e2; statement S; @@ e1 = clk_get@p1(…); … when != e1 = …
Jun 01 2011
drivers/usb/host/ohci-pxa27x.c: add missing clk_put
Author: Julia Lawall <julia@diku.dk> Add a label before the call to clk_put and jump to that in the error handling code that occurs after the call to clk_get has succeeded. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @r exists@ expression e1,e2; statement S; @@ e1 = …
