Author: Julia Lawall <Julia.Lawall@lip6.fr> devm free functions should not have to be explicitly used. A semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ @@ ( * devm_kfree(…); | * devm_free_irq(…); | * devm_iounmap(…); | * devm_release_region(…); | * devm_release_mem_region(…); ) // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/tty/serial/sirfsoc_uart.c | 8 …
Sep 01 2012
spi: spi-sh-hspi: drop frees of devm_ alloc’d data
Author: Julia Lawall <Julia.Lawall@lip6.fr> devm free functions should not have to be explicitly used. A semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ @@ ( * devm_kfree(…); | * devm_free_irq(…); | * devm_iounmap(…); | * devm_release_region(…); | * devm_release_mem_region(…); ) // Signed-off-by: Julia Lawall Signed-off-by: Mark Brown — drivers/spi/spi-sh-hspi.c | 5 …
Aug 30 2012
ASoC: wm0010: Add missing IRQF_ONESHOT
Author: Fengguang Wu <fengguang.wu@intel.com> FYI, there are new coccinelle warnings show up in tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-3.7 head: e3523e01869da20fdd12ffd19ae1df7bf492650e commit: e3523e01869da20fdd12ffd19ae1df7bf492650e [95/95] ASoC: wm0010: Add initial wm0010 DSP driver All coccinelle warnings: + sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT — + sound/soc/codecs/wm0010.c:660:1-7: preceding lock on line 359 vim +850 sound/soc/codecs/wm0010.c 847 …
Aug 29 2012
netfilter: nfnetlink_log: fix error return code in init path
Author: Julia Lawall <Julia.Lawall@lip6.fr> Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret …
Aug 29 2012
netfilter: ctnetlink: fix error return code in init path
Author: Julia Lawall <Julia.Lawall@lip6.fr> Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret …
Aug 29 2012
net/xfrm/xfrm_state.c: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret …
Aug 29 2012
net: ipv6: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Initialize return variable before exiting on an error path. The initial initialization of the return variable is also dropped, because that value is never used. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return …
Aug 29 2012
ipvs: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Initialize return variable before exiting on an error path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret …
Aug 27 2012
USB: cp210x: remove useless set memory to zero use memset()
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> The memory return by kzalloc() or kmem_cache_zalloc() has already be set to zero, so remove useless memset(0). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Greg Kroah-Hartman — drivers/usb/serial/cp210x.c | 1 – 1 file changed, 1 deletion(-) diff –git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c index …
Aug 27 2012
dmaengine: use kmem_cache_zalloc instead of kmem_cache_alloc/memset
Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn> Using kmem_cache_zalloc() instead of kmem_cache_alloc() and memset(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Vinod Koul — drivers/dma/ioat/dma_v2.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/drivers/dma/ioat/dma_v2.c b/drivers/dma/ioat/dma_v2.c index 8689576..b9d6678 100644 — a/drivers/dma/ioat/dma_v2.c +++ b/drivers/dma/ioat/dma_v2.c @@ -434,12 …
