Aug 04 2012

mfd: palmas: Drop kfree of devm_kzalloc’s data 

Author: Julia Lawall <Julia.Lawall@lip6.fr>

Using kfree to free data allocated with devm_kzalloc causes double frees.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// 
@@
expression x;
@@

x = devm_kzalloc(...)
...
?-kfree(x);
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Samuel Ortiz 

---
 drivers/mfd/palmas.c | 1 -
 1 file changed, 1 deletion(-)
 
diff --git a/drivers/mfd/palmas.c b/drivers/mfd/palmas.c
index a345f9bb..e7a7415 100644
--- a/drivers/mfd/palmas.c
+++ b/drivers/mfd/palmas.c
@@ -464,7 +464,6 @@ static int __devinit palmas_i2c_probe(struct i2c_client *i2c,
 
 err:
 	mfd_remove_devices(palmas->dev);
-	kfree(palmas);
 	return ret;
 }

qlambert