[media] mn88472: Deletion of an unnecessary check before the function call « release_firmware »
Author: Markus Elfring <elfring@users.sourceforge.net>
The release_firmware() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
Signed-off-by: Mauro Carvalho Chehab
---
drivers/staging/media/mn88472/mn88472.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
index 6eebe56..ce14cb2 100644
--- a/drivers/staging/media/mn88472/mn88472.c
+++ b/drivers/staging/media/mn88472/mn88472.c
@@ -299,8 +299,7 @@ static int mn88472_init(struct dvb_frontend *fe)
return 0;
err:
- if (fw)
- release_firmware(fw);
+ release_firmware(fw);
dev_dbg(&client->dev, "failed=%d\n", ret);
return ret; |
---
drivers/staging/media/mn88472/mn88472.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media/mn88472/mn88472.c b/drivers/staging/media/mn88472/mn88472.c
index 6eebe56..ce14cb2 100644
--- a/drivers/staging/media/mn88472/mn88472.c
+++ b/drivers/staging/media/mn88472/mn88472.c
@@ -299,8 +299,7 @@ static int mn88472_init(struct dvb_frontend *fe)
return 0;
err:
- if (fw)
- release_firmware(fw);
+ release_firmware(fw);
dev_dbg(&client->dev, "failed=%d\n", ret);
return ret;