Nov 13 2015

GFS2: Delete an unnecessary check before the function call « iput »

Classé dans Coccinelle, Linux

Author: Markus Elfring <elfring@users.sourceforge.net>

The iput() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring 
Signed-off-by: Bob Peterson

---
 fs/gfs2/ops_fstype.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index baab99b..1f9de17 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -910,8 +910,7 @@ fail_qc_i:
 fail_ut_i:
 	iput(sdp->sd_sc_inode);
 fail:
-	if (pn)
-		iput(pn);
+	iput(pn);
 	return error;
 }

6fde22426be6af261816db5941744b8d3c4c7f96

qlambert

Sites Generator / SEISM / DSI / INRIA

Construit avec par Thèmes Graphene.

Mentions légales & CGU & Politique de confidentialité & Cookies