Catégorie : Linux

selftests/timers: fix write return value handlng

Author: Andrzej Hajda <a.hajda@samsung.com> The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Signed-off-by: John Stultz — tools/testing/selftests/timers/clocksource-switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/tools/testing/selftests/timers/clocksource-switch.c b/tools/testing/selftests/timers/clocksource-switch.c index 627ec74..fd88e30 100644 — a/tools/testing/selftests/timers/clocksource-switch.c +++ b/tools/testing/selftests/timers/clocksource-switch.c @@ -97,7 …

Lire la suite

usb: host: ehci-msm: fix handling platform_get_irq result

Author: Andrzej Hajda <a.hajda@samsung.com> The function can return negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Acked-by: Alan Stern Signed-off-by: Greg Kroah-Hartman — drivers/usb/host/ehci-msm.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-)   diff –git a/drivers/usb/host/ehci-msm.c b/drivers/usb/host/ehci-msm.c index 275c92e..c4f84c8 100644 — a/drivers/usb/host/ehci-msm.c +++ …

Lire la suite

tty: serial: lpc32xx_hs: fix handling platform_get_irq result

Author: Andrzej Hajda <a.hajda@samsung.com> The function can return negative values. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Signed-off-by: Greg Kroah-Hartman — drivers/tty/serial/lpc32xx_hs.c | 7 ++++— 1 file changed, 4 insertions(+), 3 deletions(-)   diff –git a/drivers/tty/serial/lpc32xx_hs.c b/drivers/tty/serial/lpc32xx_hs.c index e92d7eb..7eb04ae 100644 — a/drivers/tty/serial/lpc32xx_hs.c +++ b/drivers/tty/serial/lpc32xx_hs.c @@ -691,12 …

Lire la suite

staging: lustre: fix handling lustre_posix_acl_xattr_filter result

Author: Andrzej Hajda <a.hajda@samsung.com> The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/llite/xattr.c | 7 ++++— 1 file changed, 4 insertions(+), 3 deletions(-)   diff –git a/drivers/staging/lustre/lustre/llite/xattr.c b/drivers/staging/lustre/lustre/llite/xattr.c index 362a87d..dddc1ff 100644 — a/drivers/staging/lustre/lustre/llite/xattr.c +++ b/drivers/staging/lustre/lustre/llite/xattr.c @@ -175,11 …

Lire la suite

IB/ehca: fix handling idr_alloc result

Author: Andrzej Hajda <a.hajda@samsung.com> The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Acked-by: Doug Ledford Signed-off-by: Greg Kroah-Hartman — drivers/staging/rdma/ehca/ehca_cq.c | 13 +++++++—— 1 file changed, 7 insertions(+), 6 deletions(-)   diff –git a/drivers/staging/rdma/ehca/ehca_cq.c b/drivers/staging/rdma/ehca/ehca_cq.c index 9b68b17..ea1b5c1 100644 — a/drivers/staging/rdma/ehca/ehca_cq.c +++ …

Lire la suite

drm/i915: fix handling gen8_emit_flush_coherentl3_wa result

Author: Andrzej Hajda <a.hajda@samsung.com> The function can return negative value. The problem has been detected using proposed semantic patch scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1]. [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576 Signed-off-by: Andrzej Hajda Reviewed-by: Jani Nikula Signed-off-by: Daniel Vetter — drivers/gpu/drm/i915/intel_lrc.c | 7 ++++— 1 file changed, 4 insertions(+), 3 deletions(-)   diff –git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index fe06accb0..ff9a481 100644 — a/drivers/gpu/drm/i915/intel_lrc.c +++ …

Lire la suite

perf tools: Bool functions shouldn’t return -1

Author: Peter Senna Tschudin <peter.senna@gmail.com> Returning a negative value for a boolean function seem to have the undesired effect of returning true. Replace -1 by false in a bool-returning function. The diff of the .s file before and after the change (for x86_64): 3907c3907 < movl $1, %ebx --- > xorl %ebx, %ebx while if …

Lire la suite

ASoC: qcom: change PTR_ERR argument

Author: Julia Lawall <julia.lawall@lip6.fr> Apply PTR_ERR to the value that was recently assigned. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,y; @@ if (IS_ERR(x) || …) { … when any when != IS_ERR(…) ( PTR_ERR(x) | * PTR_ERR(y) ) … when any } // Signed-off-by: Julia Lawall Signed-off-by: …

Lire la suite

ASoC: sunxi: fix platform_no_drv_owner.cocci warnings

Author: kbuild test robot <fengguang.wu@intel.com> sound/soc/sunxi/sun4i-codec.c:708:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci CC: Emilio López Signed-off-by: Fengguang Wu Signed-off-by: Mark Brown — sound/soc/sunxi/sun4i-codec.c | 1 – 1 file changed, 1 deletion(-)   diff –git a/sound/soc/sunxi/sun4i-codec.c b/sound/soc/sunxi/sun4i-codec.c …

Lire la suite

pinctrl/pistachio: Use irq_set_handler_locked

Author: Thomas Gleixner <tglx@linutronix.de> Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Search and replacement was done with coccinelle: Signed-off-by: Thomas Gleixner Cc: Julia Lawall Cc: Linus Walleij Cc: linux-gpio@vger.kernel.org — drivers/pinctrl/pinctrl-pistachio.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-)   diff –git a/drivers/pinctrl/pinctrl-pistachio.c b/drivers/pinctrl/pinctrl-pistachio.c index 3dc2ae1..f22d585 100644 — …

Lire la suite