Catégorie : Linux

fjes: Delete an unnecessary check before the function call « vfree »

Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: David S. Miller — drivers/net/fjes/fjes_hw.c | 4 +— 1 file changed, 1 insertion(+), 3 deletions(-)   diff –git a/drivers/net/fjes/fjes_hw.c b/drivers/net/fjes/fjes_hw.c index …

Lire la suite

brcm80211: Delete an unnecessary check before the function call « release_firmware »

Author: Markus Elfring <elfring@users.sourceforge.net> The release_firmware() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Arend van Spriel Signed-off-by: Kalle Valo — drivers/net/wireless/broadcom/brcm80211/brcmfmac/firmware.c | 3 +– 1 file changed, 1 insertion(+), …

Lire la suite

cpufreq: CPPC: Delete an unnecessary check before the function call kfree()

Author: Markus Elfring <elfring@users.sourceforge.net> The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Viresh Kumar Signed-off-by: Rafael J. Wysocki — drivers/cpufreq/cppc_cpufreq.c | 3 +– 1 file changed, 1 insertion(+), …

Lire la suite

[media] c8sectpfe: Delete unnecessary checks before two function calls

Author: Markus Elfring <elfring@users.sourceforge.net> The functions i2c_put_adapter() and module_put() test whether their argument is NULL and then return immediately. Thus the tests around their calls are not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Mauro Carvalho Chehab — drivers/media/platform/sti/c8sectpfe/c8sectpfe-common.c | 5 ++— 1 file changed, 2 insertions(+), 3 …

Lire la suite

pinctrl: Delete unnecessary checks

Author: Markus Elfring <elfring@users.sourceforge.net> The pinctrl_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Linus Walleij — drivers/pinctrl/bcm/pinctrl-cygnus-gpio.c | 3 +– drivers/pinctrl/pinctrl-single.c | 5 +—- 2 files changed, 2 insertions(+), …

Lire la suite

staging: most: Delete an unnecessary check before the function call « module_put »

Author: Markus Elfring <elfring@users.sourceforge.net> The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman — drivers/staging/most/mostcore/core.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff …

Lire la suite

UBIFS: Delete unnecessary checks before the function call « iput »

Author: Markus Elfring <elfring@users.sourceforge.net> The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Richard Weinberger — fs/ubifs/recovery.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-)   diff …

Lire la suite

gpio: change member .dev to .parent

Author: Linus Walleij <linus.walleij@linaro.org> The name .dev in a struct is normally reserved for a struct device that is let us say a superclass to the thing described by the struct. struct gpio_chip stands out by confusingly using a struct device *dev to point to the parent device (such as a platform_device) that represents the …

Lire la suite

batman-adv: Delete an unnecessary check before the function call « batadv_softif_vlan_free_ref »

Author: Markus Elfring <elfring@users.sourceforge.net> The batadv_softif_vlan_free_ref() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Marek Lindner Signed-off-by: Antonio Quartulli — net/batman-adv/translation-table.c | 3 +– 1 file changed, 1 insertion(+), 2 …

Lire la suite

irda: Delete an unnecessary check before the function call « irlmp_unregister_service »

Author: Markus Elfring <elfring@users.sourceforge.net> The irlmp_unregister_service() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: David S. Miller — net/irda/af_irda.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   …

Lire la suite