Catégorie : Linux

usb: host: ehci.h: move constant to right

Author: Geyslan G. Bem <geyslan@gmail.com> This patch moves the constant 0x3ff to right and put spaces in the right shift. Caught by coccinelle: scripts/coccinelle/misc/compare_const_fl.cocci Signed-off-by: Geyslan G. Bem Signed-off-by: Greg Kroah-Hartman — drivers/usb/host/ehci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h index 30bf437..d1b29b3 100644 — a/drivers/usb/host/ehci.h +++ b/drivers/usb/host/ehci.h …

Lire la suite

ALSA: bebob: Use a signed return type for get_formation_index

Author: Lucas Tanure <tanure@linux.com> The return type « unsigned int » was used by the get_formation_index function despite of the aspect that it will eventually return a negative error code. So, change to signed int and get index by reference in the parameters. Done with the help of Coccinelle. [Fix the missing braces suggested by Julia Lawall …

Lire la suite

drm/amdkfd: Remove unnecessary cast in kfree

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Remove an unnecassary cast in the argument to kfree. Found using Coccinelle. The semantic patch used to find this is as follows: // @@ type T; expression *f; @@ – kfree((T *)(f)); + kfree(f); // Signed-off-by: Amitoj Kaur Chawla Signed-off-by: Oded Gabbay — drivers/gpu/drm/amd/amdkfd/kfd_process.c | 2 +- 1 file changed, …

Lire la suite

memory: tegra: tegra124-emc: Add missing of_node_put()

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> for_each_child_of_node() performs an of_node_get() on each iteration, so to break out of the loop an of_node_put() is required. Found using Coccinelle. The semantic patch used for this is as follows: // @@ expression e; local idexpression n; @@ for_each_child_of_node(…, n) { … when != of_node_put(n) when != e = n …

Lire la suite

memory: tegra: mc: Add missing of_node_put()

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> for_each_child_of_node() performs an of_node_get() on each iteration, so to break out of the loop an of_node_put() is required. Found using Coccinelle. The semantic patch used for this is as follows: // @@ expression e; local idexpression n; @@ for_each_child_of_node(…, n) { … when != of_node_put(n) when != e = n …

Lire la suite

usb: gadget: rndis: fix itnull.cocci warnings

Author: Julia Lawall <julia.lawall@lip6.fr> The index variable of list_for_each_entry_safe is an offset from a list pointer, and thus should not be NULL. Generated by: scripts/coccinelle/iterators/itnull.cocci CC: Geliang Tang Signed-off-by: Fengguang Wu Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/usb/gadget/function/rndis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff –git a/drivers/usb/gadget/function/rndis.c b/drivers/usb/gadget/function/rndis.c index …

Lire la suite

[media] media: platform: exynos4-is: media-dev: Add missing of_node_put

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> for_each_available_child_of_node and for_each_child_of_node perform an of_node_get on each iteration, so to break out of the loop an of_node_put is required. Found using Coccinelle. The simplified version of the semantic patch that is used for this is as follows: // @@ local idexpression n; expression e,r; @@ for_each_available_child_of_node(r,n) { … ( …

Lire la suite

gpu: host1x: bus: Add missing of_node_put()

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> for_each_child_of_node() performs an of_node_get() on each iteration, so to break out of the loop an of_node_put() is required. Found using Coccinelle. The semantic patch used for this is as follows: // @@ expression e; local idexpression n; @@ for_each_child_of_node(…, n) { … when != of_node_put(n) when != e = n …

Lire la suite

clk: tegra: Add missing of_node_put()

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> for_each_child_of_node() performs an of_node_get() on each iteration, so before breaking out of the loop an of_node_put() is required. Found using Coccinelle. The semantic patch used for this is as follows: // @@ expression e; local idexpression child; @@ for_each_child_of_node(root, child) { … when != of_node_put(child) when != e = child …

Lire la suite

Staging:lustre:lustre:llite:Remove explicit NULL comparision

Author: Bhumika Goyal <bhumirks@gmail.com> Replaced explicit NULL comparision with its simplier form. Found using coccinelle: @replace_rule@ expression e; @@ -e == NULL + !e Signed-off-by: Bhumika Goyal Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/llite/dcache.c | 10 +++++—– 1 file changed, 5 insertions(+), 5 deletions(-)   diff –git a/drivers/staging/lustre/lustre/llite/dcache.c b/drivers/staging/lustre/lustre/llite/dcache.c index 3d6745e..bc179e5 100644 — a/drivers/staging/lustre/lustre/llite/dcache.c +++ b/drivers/staging/lustre/lustre/llite/dcache.c @@ …

Lire la suite