Author: Julia Lawall <julia@diku.dk> Correct priority problem in the use of ! and &. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ expression E; constant C; @@ – !E & C + !(E & C) // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8192su/ieee80211/ieee80211_wx.c | 2 +- 1 file changed, …
Catégorie : Linux
May 20 2009
Staging: cpc-usb: Adjust NULL test
Author: Julia Lawall <julia@diku.dk> Since card must already be non-NULL, it seems that what was intended was to test the result of kmalloc. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ expression E,E1; identifier f,fld,fld1; statement S1,S2; @@ E->fld = f(…); … when != E = E1 when != E->fld1 …
May 17 2009
sound: use dev_set_drvdata
Author: Julia Lawall <julia@diku.dk> Eliminate direct accesses to the driver_data field. cf 82ab13b26f15f49be45f15ccc96bfa0b81dfd015 The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ struct device *dev; expression E; type T; @@ – dev->driver_data = (T)E + dev_set_drvdata(dev, E) @@ struct device *dev; type T; @@ – (T)dev->driver_data + dev_get_drvdata(dev) // Signed-off-by: Julia …
May 17 2009
drivers/net: use dev_get_drvdata
Author: Julia Lawall <julia@diku.dk> Eliminate direct accesses to the driver_data field. cf 82ab13b26f15f49be45f15ccc96bfa0b81dfd015 The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ struct device *dev; expression E; type T; @@ – dev->driver_data = (T)E + dev_set_drvdata(dev, E) @@ struct device *dev; type T; @@ – (T)dev->driver_data + dev_get_drvdata(dev) // Signed-off-by: Julia …
May 02 2009
V4L/DVB (11674): ivtv: fix incorrect bit tests
Author: Hans Verkuil <hverkuil@xs4all.nl> Found the coccinelle tool. Thanks-to: Julia Lawall Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab — drivers/media/video/ivtv/ivtv-ioctl.c | 5 +++– drivers/media/video/ivtv/ivtv-irq.c | 2 +- drivers/media/video/ivtv/ivtv-yuv.c | 3 ++- drivers/media/video/ivtv/ivtvfb.c | 3 ++- 4 files changed, 8 insertions(+), 5 deletions(-) diff –git a/drivers/media/video/ivtv/ivtv-ioctl.c b/drivers/media/video/ivtv/ivtv-ioctl.c index 4a2d464..c342a9f 100644 — a/drivers/media/video/ivtv/ivtv-ioctl.c +++ b/drivers/media/video/ivtv/ivtv-ioctl.c @@ …
Apr 14 2009
Staging winbond: boolean negation and bitwise operation in wrong order
Author: Diego Liziero <diegoliz@gmail.com> The semantic patch that makes this change is: (http://www.emn.fr/x-info/coccinelle/) @@ expression E; constant C; @@ ( – !E == C + E != C ) Signed-off-by: Diego Liziero Signed-off-by: Greg Kroah-Hartman — drivers/staging/winbond/mds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/staging/winbond/mds.c b/drivers/staging/winbond/mds.c index c7af092..59d6d67 100644 …
Apr 14 2009
drivers/regulator: fix when type is different from REGULATOR_VOLTAGE or REGULATOR_CURRENT
Author: Diego Liziero <diegoliz@gmail.com> When regulator_desc->type is something different from REGULATOR_VOLTAGE or REGULATOR_CURRENT the if should probably return ERR_PTR(-EINVAL) The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) @@ expression E; constant C; @@ ( – !E == C + E != C ) Signed-off-by: Diego Liziero Acked-by: Mark Brown Signed-off-by: Liam Girdwood …
Mar 26 2009
[S390] list usage cleanup in s390
Author: Eric Sesterhenn <snakebyte@gmx.de> Trivial cleanup, list_del(); list_add{,_tail}() is equivalent to list_move{,_tail}(). Semantic patch for coccinelle can be found at www.cccmz.de/~snakebyte/list_move_tail.spatch Signed-off-by: Eric Sesterhenn Signed-off-by: Martin Schwidefsky — drivers/s390/crypto/zcrypt_api.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-) diff –git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index cb22b97..65b6a96 100644 — a/drivers/s390/crypto/zcrypt_api.c +++ b/drivers/s390/crypto/zcrypt_api.c @@ -128,8 +128,7 @@ …
Feb 27 2009
MISDN: list usage cleanup
Author: Eric Sesterhenn <snakebyte@gmx.de> Trivial cleanup, list_del(); list_add_tail() is equivalent to list_move_tail(). Semantic patch for coccinelle can be found at www.cccmz.de/~snakebyte/list_move_tail.spatch Signed-off-by: Eric Sesterhenn Acked-by: Karsten Keil Signed-off-by: David S. Miller — drivers/isdn/mISDN/timerdev.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/drivers/isdn/mISDN/timerdev.c b/drivers/isdn/mISDN/timerdev.c index f2b3218..bbd99d3 100644 — a/drivers/isdn/mISDN/timerdev.c +++ b/drivers/isdn/mISDN/timerdev.c …
Feb 26 2009
I/OAT: list usage cleanup
Author: Eric Sesterhenn <snakebyte@gmx.de> Trivial cleanup, list_del(); list_add_tail() is equivalent to list_move_tail(). Semantic patch for coccinelle can be found at www.cccmz.de/~snakebyte/list_move_tail.spatch Signed-off-by: Eric Sesterhenn Signed-off-by: Maciej Sosnowski Signed-off-by: Shannon Nelson Acked-by: Jeff Kirsher Signed-off-by: Dan Williams — drivers/dma/ioat_dma.c | 5 ++— 1 file changed, 2 insertions(+), 3 deletions(-) diff –git a/drivers/dma/ioat_dma.c b/drivers/dma/ioat_dma.c index fc9b845..ae8c0ce …