Author: Julia Lawall <Julia.Lawall@lip6.fr> Add missing iounmap in error handling code, in a case where the function already preforms iounmap on some other execution path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; statement S,S1; int ret; @@ e = \(ioremap\|ioremap_nocache\)(…) … when != …
Catégorie : Linux
Jan 12 2012
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c: add missing iounmap
Author: Julia Lawall <Julia.Lawall@lip6.fr> Add missing iounmap in error handling code, in a case where the function already preforms iounmap on some other execution path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; statement S,S1; int ret; @@ e = \(ioremap\|ioremap_nocache\)(…) … when != …
Jan 12 2012
drivers/net/ethernet/tundra/tsi108_eth.c: add missing iounmap
Author: Julia Lawall <Julia.Lawall@lip6.fr> Add missing iounmap in error handling code, in a case where the function already preforms iounmap on some other execution path. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; statement S,S1; int ret; @@ e = \(ioremap\|ioremap_nocache\)(…) … when != …
Jan 11 2012
drivers/rtc/: remove redundant spi driver bus initialization
Author: Lars-Peter Clausen <lars@metafoo.de> In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_driver_register(), so we can drop the manual assignment. The patch was generated using the following coccinelle semantic patch: // @@ identifier _driver; @@ struct spi_driver _driver = { …
Jan 09 2012
drivers/net/wireless/mwifiex/scan.c: convert GFP_KERNEL to GFP_ATOMIC
Author: Julia Lawall <julia.lawall@lip6.fr> The function is called with locks held and thus should not use GFP_KERNEL. The semantic patch that makes this report is available in scripts/coccinelle/locks/call_kern.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Julia Lawall Acked-by: Bing Zhao Signed-off-by: John W. Linville — drivers/net/wireless/mwifiex/scan.c | 2 +- 1 file changed, …
Jan 09 2012
crypto: ixp4xx – convert GFP_KERNEL to GFP_ATOMIC
Author: Julia Lawall <julia.lawall@lip6.fr> The function is called with locks held and thus should not use GFP_KERNEL. The semantic patch that makes this report is available in scripts/coccinelle/locks/call_kern.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Julia Lawall Signed-off-by: Herbert Xu — drivers/crypto/ixp4xx_crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) …
Jan 09 2012
IB/qib: Use GFP_ATOMIC when locks are held
Author: Julia Lawall <julia.lawall@lip6.fr> alloc_dummy_hdrq() is called with locks held and thus should not use GFP_KERNEL. The semantic patch that makes this report is available in scripts/coccinelle/locks/call_kern.cocci. Signed-off-by: Julia Lawall Acked-by: Mike Marciniszyn Signed-off-by: Roland Dreier — drivers/infiniband/hw/qib/qib_iba6120.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/infiniband/hw/qib/qib_iba6120.c b/drivers/infiniband/hw/qib/qib_iba6120.c index 4f18e2d..d0c64d5 …
Jan 09 2012
drivers/staging/omapdrm/omap_fbdev.c: move free after uses
Author: Julia Lawall <julia@diku.dk> Move the free after the final uses. The semantic patch that makes this report is available in scripts/coccinelle/free/kfree.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/omapdrm/omap_fbdev.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-) diff –git a/drivers/staging/omapdrm/omap_fbdev.c b/drivers/staging/omapdrm/omap_fbdev.c index …
Dec 27 2011
mtd: txx9ndfmc: use devm_request_and_ioremap
Author: Julia Lawall <julia@diku.dk> Reimplement a call to devm_request_mem_region followed by a call to ioremap or ioremap_nocache by a call to devm_request_and_ioremap. The semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @nm@ expression myname; identifier i; @@ struct platform_driver i = { .driver = { .name = myname } }; @@ expression …
Dec 27 2011
hwrng: tx4939 – use devm_request_and_ioremap
Author: Julia Lawall <julia@diku.dk> Reimplement a call to devm_request_mem_region followed by a call to ioremap or ioremap_nocache by a call to devm_request_and_ioremap. The semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @nm@ expression myname; identifier i; @@ struct platform_driver i = { .driver = { .name = myname } }; @@ expression …