Author: Fengguang Wu <fengguang.wu@intel.com> Fix a real bug caught by coccinelle. fs/btrfs/delayed-inode.c:1013:1-11: second lock on line 1013 Signed-off-by: Fengguang Wu — fs/btrfs/delayed-inode.c | 5 +++– 1 file changed, 3 insertions(+), 2 deletions(-) diff –git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c index 335605c..00deed4e 100644 — a/fs/btrfs/delayed-inode.c +++ b/fs/btrfs/delayed-inode.c @@ -1028,9 +1028,10 @@ do_again: btrfs_release_delayed_item(prev); ret = 0; btrfs_release_path(path); – …
Catégorie : Linux
Aug 04 2012
drivers/net/phy/mdio-mux-gpio.c: drop devm_kfree of devm_kzalloc’d data
Author: Julia Lawall <Julia.Lawall@lip6.fr> devm_kfree should not have to be explicitly used. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,d; @@ x = devm_kzalloc(…) … ?-devm_kfree(d,x); // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller — drivers/net/phy/mdio-mux-gpio.c | 1 – 1 file changed, 1 deletion(-) diff –git a/drivers/net/phy/mdio-mux-gpio.c …
Jul 31 2012
tcm_vhost: Fix incorrect IS_ERR() usage in vhost_scsi_map_iov_to_sgl
Author: Fengguang Wu <fengguang.wu@intel.com> Fix up a new coccinelle warnings reported by Fengguang Wu + Intel 0-DAY kernel build testing backend: drivers/vhost/tcm_vhost.c:537:23-29: ERROR: allocation function on line 533 returns NULL not ERR_PTR on failure vim +537 drivers/vhost/tcm_vhost.c 534 if (!sg) 535 return -ENOMEM; 536 pr_debug(« %s sg %p sgl_count %u is_err %ld\n », __func__, > 537 sg, …
Jul 28 2012
netfilter: PTR_RET can be used
Author: Wu Fengguang <fengguang.wu@intel.com> This quiets the coccinelle warnings: net/bridge/netfilter/ebtable_filter.c:107:1-3: WARNING: PTR_RET can be used net/bridge/netfilter/ebtable_nat.c:107:1-3: WARNING: PTR_RET can be used net/ipv6/netfilter/ip6table_filter.c:65:1-3: WARNING: PTR_RET can be used net/ipv6/netfilter/ip6table_mangle.c:100:1-3: WARNING: PTR_RET can be used net/ipv6/netfilter/ip6table_raw.c:44:1-3: WARNING: PTR_RET can be used net/ipv6/netfilter/ip6table_security.c:62:1-3: WARNING: PTR_RET can be used net/ipv4/netfilter/iptable_filter.c:72:1-3: WARNING: PTR_RET can be used net/ipv4/netfilter/iptable_mangle.c:107:1-3: WARNING: PTR_RET can …
Jul 28 2012
pch_uart: check kzalloc result in dma_handle_tx()
Author: Fengguang Wu <fengguang.wu@intel.com> Reported by coccinelle: drivers/tty/serial/pch_uart.c:979:1-14: alloc with no test, possible model on line 994 Signed-off-by: Fengguang Wu Signed-off-by: Greg Kroah-Hartman — drivers/tty/serial/pch_uart.c | 4 ++++ 1 file changed, 4 insertions(+) diff –git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 558ce85..4cd6c23 100644 — a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -979,6 +979,10 @@ static unsigned int dma_handle_tx(struct eg20t_port *priv) …
Jul 28 2012
floppy: remove duplicated flag FD_RAW_NEED_DISK
Author: Fengguang Wu <fengguang.wu@intel.com> Fix coccinelle warning (without behavior change): drivers/block/floppy.c:2518:32-48: duplicated argument to & or | Signed-off-by: Fengguang Wu Signed-off-by: Jiri Kosina — drivers/block/floppy.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/drivers/block/floppy.c b/drivers/block/floppy.c index 1347ba8..9d6ef68 100644 — a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -2516,8 +2516,7 @@ static int make_raw_rw_request(void) set_fdc((long)current_req->rq_disk->private_data); …
Jul 28 2012
RDMA/ucma: Convert open-coded equivalent to memdup_user()
Author: Roland Dreier <roland@purestorage.com> Suggested by scripts/coccinelle/api/memdup_user.cocci. Reported-by: Fengguang Wu Signed-off-by: Roland Dreier — drivers/infiniband/core/ucma.c | 19 +++++++———— 1 file changed, 7 insertions(+), 12 deletions(-) diff –git a/drivers/infiniband/core/ucma.c b/drivers/infiniband/core/ucma.c index 893cb87..6bf8504 100644 — a/drivers/infiniband/core/ucma.c +++ b/drivers/infiniband/core/ucma.c @@ -1002,23 +1002,18 @@ static ssize_t ucma_set_option(struct ucma_file *file, const char __user *inbuf, if (IS_ERR(ctx)) return PTR_ERR(ctx); …
Jul 28 2012
RDMA/ocrdma: Fix check of GSI CQs
Author: Roland Dreier <roland@purestorage.com> It looks like one check was accidentally duplicated, and the other 3 checks were left out. This was detected by scripts/coccinelle/tests/doubletest.cocci: drivers/infiniband/hw/ocrdma/ocrdma_verbs.c:895:6-54: duplicated argument to && or || Reported-by: Fengguang Wu Signed-off-by: Roland Dreier — drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff –git a/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c b/drivers/infiniband/hw/ocrdma/ocrdma_verbs.c …
Jul 28 2012
RDMA/cma: Use PTR_RET rather than if (IS_ERR(…)) + PTR_ERR
Author: Fengguang Wu <fengguang.wu@intel.com> Suggested by scripts/coccinelle/api/ptr_ret.cocci. Signed-off-by: Roland Dreier — drivers/infiniband/core/cma.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-) diff –git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index 5a335b5..7172559 100644 — a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -3064,10 +3064,7 @@ static int cma_join_ib_multicast(struct rdma_id_private *id_priv, id_priv->id.port_num, &rec, comp_mask, GFP_KERNEL, cma_ib_mc_handler, mc); – if (IS_ERR(mc->multicast.ib)) – return PTR_ERR(mc->multicast.ib); …
Jul 26 2012
bcma: add missing iounmap on error path
Author: Hauke Mehrtens <hauke@hauke-m.de> This should fix the problem reported by Fengguang: The coccinelle static checker emits these warnings: drivers/bcma/scan.c:466:3-9: ERROR: missing iounmap; ioremap on line 451 and execution via conditional on line 465 drivers/bcma/scan.c:540:3-9: ERROR: missing iounmap; ioremap on line 515 and execution via conditional on line 539 Reported-by: Fengguang Wu Signed-off-by: Hauke Mehrtens …