Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for atmel_priv_ioctl. The following Coccinelle semantic patch detects the case: @tn@ identifier i; type td; @@ -typedef struct i { … } -td ; @@ type tn.td; identifier tn.i; @@ -td …
Catégorie : Linux
Aug 09 2014
com20020_cs: Remove typedef com20020_dev_t
Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for com20020_dev_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case: @tn@ identifier …
Aug 09 2014
ethernet: amd: Remove typedef local_info_t
Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for local_info_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case: @tn@ identifier …
Aug 08 2014
PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use
Author: Benoit Taine <benoit.taine@lip6.fr> We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // @@ identifier i; declarer name DEFINE_PCI_DEVICE_TABLE; initializer z; @@ – DEFINE_PCI_DEVICE_TABLE(i) + const struct pci_device_id i[] …
Aug 08 2014
video: of: display_timing: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Furthermore, native_mode cannot be NULL at this point. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Signed-off-by: Tomi Valkeinen …
Aug 08 2014
fec_mpc52xx: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller — drivers/net/ethernet/freescale/fec_mpc52xx.c | 3 +– 1 file …
Aug 08 2014
ll_temac: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Reviewed-by: Michal Simek Signed-off-by: David S. Miller — drivers/net/ethernet/xilinx/ll_temac_main.c | 3 …
Aug 08 2014
gpio: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Signed-off-by: Linus Walleij — drivers/gpio/gpiolib-of.c | 4 +— 1 file changed, …
Aug 08 2014
imx-drm: imx-drm-core: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/imx-drm/imx-drm-core.c | 3 +– 1 file changed, …
Aug 08 2014
ASoC: rsnd: delete unneeded test before of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> Of_node_put supports NULL as its argument, so the initial test is not necessary. Suggested by Uwe Kleine-König. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ -if (e) of_node_put(e); // Signed-off-by: Julia Lawall Signed-off-by: Mark Brown — sound/soc/sh/rcar/core.c | 6 ++—- 1 file changed, …
