Catégorie : Linux

Bluetooth: Remove typedefs nsh_t and dtl1_info_t

Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedefs for nsh_t and dtl1_info_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case …

Lire la suite

Bluetooth: Remove typedef btuart_info_t

Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for btuart_info_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case: @tn@ identifier …

Lire la suite

Bluetooth: Remove typedef bt3c_info_t

Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for bt3c_info_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case: @tn@ identifier …

Lire la suite

powerpc/pseries: Drop unnecessary continue

Author: Himangi Saraogi <himangi774@gmail.com> Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (…;…;…) { … if (…) { … – continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Signed-off-by: Michael Ellerman — arch/powerpc/platforms/pseries/cmm.c | 1 – 1 file changed, 1 deletion(-) …

Lire la suite

rtlwifi: btcoexist: adjust double test

Author: Himangi Saraogi <himangi774@gmail.com> Rewrite a duplicated test to test the correct value The Coccinelle semantic patch that finds this problem is: // @@ expression E; @@ ( * E || … || E | * E && … && E ) // Signed-off-by: Himangi Saraogi Acked-by: Larry.Finger Signed-off-by: John W. Linville — drivers/net/wireless/rtlwifi/btcoexist/halbtcoutsrc.c | …

Lire la suite

usb: phy: drop kfree of devm_kzalloc’s data

Author: Himangi Saraogi <himangi774@gmail.com> Using kfree to free data allocated with devm_kzalloc causes double frees. The Coccinelle semantic patch that fixes this problem is as follows: // @@ expression x; @@ x = devm_kzalloc(…) … ?-kfree(x); // Reviewed-by: Jingoo Han Acked-by: Julia Lawall Signed-off-by: Himangi Saraogi Signed-off-by: Felipe Balbi — drivers/usb/phy/phy-gpio-vbus-usb.c | 4 +— 1 …

Lire la suite

wan: wanxl: Remove typedefs from struct names

Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedefs for port_t, card_status_t and card_t. Also, the names of the structs are changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects two …

Lire la suite

hdlc: Remove typedefs from struct names

Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedefs for fr_hdr and pvc_device. Also, the names of the structs are changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case …

Lire la suite

airo_cs: Remove typedef local_info_t

Author: Himangi Saraogi <himangi774@gmail.com> The Linux kernel coding style guidelines suggest not using typedefs for structure types. This patch gets rid of the typedef for local_info_t. Also, the name of the struct is changed to drop the _t, to make the name look less typedef-like. The following Coccinelle semantic patch detects the case: @tn@ identifier …

Lire la suite

mfd: menelaus: Remove null pointer dereference

Author: Himangi Saraogi <himangi774@gmail.com> If vtg is NULL, it is not possible to access its mode_reg field. At all sites where the static function menelaus_set_voltage is called, the first argument is the address of a structure defined in the file. So, the null test is unnecessary and is removed. Also, a label is done away …

Lire la suite