Catégorie : Linux

irqf_oneshot.cocci: add check of devm_request_threaded_irq()

Author: Valentin Rothberg <valentinrothberg@gmail.com> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 (« genirq: Reject bogus threaded irq requests ») threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. Until now, this coccinelle script only checked request_threaded_irq(). However, the counterpart devm function (see kernel/irq/devres.c) is also affected by the missing flag which can be …

Lire la suite

staging: rtl8712: replace memset(x,0,ETH_ALEN)

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The aforementioned function replaces memset. In addition, linux/etherdevice.h was included as a header since it is the file that defines the inline function eth_zero_addr(). The changes were carried out using the following coccinelle …

Lire la suite

staging: rtl8188eu: replace memset(x,0,ETH_ALEN)

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The aforementioned function replaces memset. In addition, linux/etherdevice.h was included as a header since it is the file that define the inline function eth_zero_addr(). The changes were carried out using the following coccinelle …

Lire la suite

staging: unisys: virthba: remove extra parentheses around left bit shift operations

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise left shift operations. The case handled is when resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1

staging: slicoss: remove extra parentheses around left bit shift operations

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise left shift operations. The case handled is when resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1

staging: rts5208: remove extra parentheses around left bit shift operation

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise left shift operations. The case handled is when resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1

staging: ozwpan: remove extra parentheses around left bit shift operations

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise left shift operations. The case handled is when resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1

staging: lustre: remove extra parentheses around left bit shift operations

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise left shift operations. The cases handled here are when resultant values are assigned to variables. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1

staging: xgifb: remove extra parentheses around right bit shift operations

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operations. The cases handled here are when resultant values are assigned to variables. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant c; type …

Lire la suite

staging: speakup: remove extra parentheses around right bit shift operation

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> Removes extra parentheses around bitwise right shift operation. The case handled is when the resultant value is assigned to a variable. The issue was detected and resolved using the following coccinelle script: @@ expression e, e1; constant c; @@ e = -(e1 +e1 >> -c); +c; @@ identifier i; constant c; …

Lire la suite