Author: Tina Johnson <tinajohnson.1234@gmail.com> Variable len is used only to store the return value. Hence len is removed and the return statement modified. Coccinelle was used to detect such removable variables: @rule1@ identifier ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Tina Johnson Signed-off-by: Greg Kroah-Hartman — drivers/staging/iio/accel/sca3000_core.c | 6 ++—- 1 …
Catégorie : Linux
Mar 09 2015
Staging rtl8172: Remove unnecessary typecast
Author: Vatika Harlalka <vatikaharlalka@gmail.com> Using addressof and then casting to the original type is unneeded. So these casts can be removed. Issue detected via Coccinelle script. Signed-off-by: Vatika Harlalka Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8712/hal_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/staging/rtl8712/hal_init.c b/drivers/staging/rtl8712/hal_init.c index 324da34..0a1c631 100644 — a/drivers/staging/rtl8712/hal_init.c +++ …
Mar 09 2015
drivers: staging: rtl8723au: hal: Removed unnecessary parentheses
Author: Tina Johnson <tinajohnson.1234@gmail.com> Parentheses around the right side of an assignment statement are unnecessary and hence removed. Coccinelle was used to produce the patch: @rule1@ identifier x,y; constant c; @@ ( x = -( y > c -) ; | x = -( y + c -) ; | x = -( y – …
Mar 09 2015
drivers: staging: rtl8723au: core: Removed unnecessary parentheses
Author: Tina Johnson <tinajohnson.1234@gmail.com> Parentheses around the right side of an assignment statement are unnecessary and hence removed. Coccinelle was used to produce the patch: @rule1@ identifier x,y; constant c; @@ ( x = -( y > c -) ; | x = -( y + c -) ; | x = -( y – …
Mar 09 2015
drivers: staging: rtl8712: Removed unnecessary parentheses
Author: Tina Johnson <tinajohnson.1234@gmail.com> Parentheses around the right side of an assignment statement are unnecessary and hence removed. Coccinelle was used to produce the patch: @rule1@ identifier x,y; constant c; @@ ( x = -( y > c -) ; | x = -( y + c -) ; | x = -( y – …
Mar 09 2015
drivers: staging: rtl8188eu: core: Removed unnecessary parentheses
Author: Tina Johnson <tinajohnson.1234@gmail.com> Parentheses around the right side of an assignment statement are unnecessary and hence removed. Coccinelle was used to produce the patch: @rule1@ identifier x,y; constant c; @@ ( x = -( y > c -) ; | x = -( y + c -) ; | x = -( y – …
Mar 08 2015
staging: fbtft: Use kmemdup rather than duplicating its implementation
Author: Madhusudhanan Ravindran <mravindran04@gmail.com> The semantic patch that makes this change is available in scriptcoccinelle/api/memdup.cocci. Signed-off-by: Madhusudhanan Ravindran Signed-off-by: Greg Kroah-Hartman — drivers/staging/fbtft/fbtft-sysfs.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/drivers/staging/fbtft/fbtft-sysfs.c b/drivers/staging/fbtft/fbtft-sysfs.c index 45f8de3..ba4551f 100644 — a/drivers/staging/fbtft/fbtft-sysfs.c +++ b/drivers/staging/fbtft/fbtft-sysfs.c @@ -37,10 +37,9 @@ int fbtft_gamma_parse_str(struct fbtft_par *par, unsigned long …
Mar 07 2015
Staging: speakup: Remove unused variable
Author: Haneen Mohammed <hamohammed.sa@gmail.com> This patch removes variable that was used to store only the return value of a function call. The issue was detected and resolved using the following coccinelle script: @@ expression ret; identifier f; @@ -ret = +return f(…); -return ret; Signed-off-by: Haneen Mohammed Signed-off-by: Greg Kroah-Hartman — drivers/staging/speakup/kobjects.c | 4 +— …
Mar 07 2015
Staging: dgap: Remove unused variable
Author: Haneen Mohammed <hamohammed.sa@gmail.com> This patch removes variable that was used to store only the return value of a function call. The issue was detected and resolved using the following coccinelle script: @@ expression ret; identifier f; @@ -ret = +return f(…); -return ret; Signed-off-by: Haneen Mohammed Reviewed-by: Daniel Baluta Signed-off-by: Greg Kroah-Hartman — drivers/staging/dgap/dgap.c …
Mar 06 2015
Staging: ste_rmi4: clean dev_err logging
Author: Haneen Mohammed <hamohammed.sa@gmail.com> This patch removes __func__ from dev_err. dev_err includes information about: (devcice, driver, specific instance of device, etc) in the log printout. This was done using Coccinelle, with the following semantic patch: @a@ expression E, R; expression msg; @@ dev_err(E, msg, __func__, R); @script:python b@ e