Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org> We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. CC: Jiri Slaby Signed-off-by: Greg Kroah-Hartman — drivers/tty/serial/68328serial.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff –git a/drivers/tty/serial/68328serial.c b/drivers/tty/serial/68328serial.c index 5dc9c4b..748c18f 100644 …
Catégorie : Linux
Apr 29 2015
Staging: iop.c: move assignment out of if () block
Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org> We should not be doing assignments within an if () block so fix up the code to not do this. change was created using Coccinelle. CC: Supriya Karanth CC: Somya Anand CC: Alan Cox Signed-off-by: Greg Kroah-Hartman — drivers/staging/i2o/iop.c | 9 ++++++— 1 file changed, 6 insertions(+), 3 deletions(-) diff …
Apr 29 2015
Thermal: Intel SoC: fix simple_return.cocci warnings
Author: Wu Fengguang <fengguang.wu@intel.com> drivers/thermal/intel_soc_dts_iosf.c:358:4-7: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci CC: Srinivas Pandruvada Signed-off-by: Fengguang Wu Signed-off-by: Zhang Rui — drivers/thermal/intel_soc_dts_iosf.c | 7 +—— 1 file changed, 1 insertion(+), 6 deletions(-) diff –git a/drivers/thermal/intel_soc_dts_iosf.c b/drivers/thermal/intel_soc_dts_iosf.c index d897876..42e4b6a 100644 …
Apr 28 2015
iwlwifi: pcie: simplify return value
Author: Emmanuel Grumbach <emmanuel.grumbach@intel.com> This was spot by Coccinelle. Signed-off-by: Emmanuel Grumbach — drivers/net/wireless/iwlwifi/pcie/trans.c | 8 ++—— 1 file changed, 2 insertions(+), 6 deletions(-) diff –git a/drivers/net/wireless/iwlwifi/pcie/trans.c b/drivers/net/wireless/iwlwifi/pcie/trans.c index 5c523a7..a341ed9 100644 — a/drivers/net/wireless/iwlwifi/pcie/trans.c +++ b/drivers/net/wireless/iwlwifi/pcie/trans.c @@ -973,12 +973,8 @@ static int iwl_pcie_load_given_ucode_8000(struct iwl_trans *trans, return ret; /* load to FW the binary sections …
Apr 28 2015
ASoC: ssm2518: fix simple_return.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> sound/soc/codecs/ssm2518.c:521:5-8: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu Signed-off-by: Mark Brown — sound/soc/codecs/ssm2518.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-) diff –git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c index 40b22b3..13c6ab0 100644 — a/sound/soc/codecs/ssm2518.c …
Apr 28 2015
ASoC: adau1977: fix simple_return.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> sound/soc/codecs/adau1977.c:496:5-8: WARNING: end returns can be simpified Simplify a trivial if-return sequence. Possibly combine with a preceding function call. Generated by: scripts/coccinelle/misc/simple_return.cocci Signed-off-by: Fengguang Wu Signed-off-by: Mark Brown — sound/soc/codecs/adau1977.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-) diff –git a/sound/soc/codecs/adau1977.c b/sound/soc/codecs/adau1977.c index c5b1b8e..3fb09c1 100644 — a/sound/soc/codecs/adau1977.c …
Apr 28 2015
KVM: x86: drop unneeded null test
Author: Julia Lawall <Julia.Lawall@lip6.fr> If the null test is needed, the call to cancel_delayed_work_sync would have already crashed. Normally, the destroy function should only be called if the init function has succeeded, in which case ioapic is not null. Problem found using Coccinelle. Suggested-by: Michael S. Tsirkin Signed-off-by: Julia Lawall Signed-off-by: Paolo Bonzini — arch/x86/kvm/ioapic.c …
Apr 27 2015
pinctrl: use ERR_CAST instead of ERR_PTR/PTR_ERR
Author: Fabian Frederick <fabf@skynet.be> Inspired by scripts/coccinelle/api/err_cast.cocci Signed-off-by: Fabian Frederick Signed-off-by: Linus Walleij — include/linux/pinctrl/consumer.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/include/linux/pinctrl/consumer.h b/include/linux/pinctrl/consumer.h index 18eccef..d7e5d60 100644 — a/include/linux/pinctrl/consumer.h +++ b/include/linux/pinctrl/consumer.h @@ -142,7 +142,7 @@ static inline struct pinctrl * __must_check pinctrl_get_select( s = pinctrl_lookup_state(p, name); if (IS_ERR(s)) { …
Apr 25 2015
drm/i915: use ERR_CAST instead of ERR_PTR/PTR_ERR
Author: Fabian Frederick <fabf@skynet.be> Inspired by scripts/coccinelle/api/err_cast.cocci Signed-off-by: Fabian Frederick Reviewed-by: Jani Nikula Signed-off-by: Daniel Vetter — drivers/gpu/drm/i915/intel_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h index ddf3fefd..ea20edb 100644 — a/drivers/gpu/drm/i915/intel_drv.h +++ b/drivers/gpu/drm/i915/intel_drv.h @@ -1419,7 +1419,7 @@ intel_atomic_get_crtc_state(struct drm_atomic_state *state, struct drm_crtc_state *crtc_state; crtc_state = drm_atomic_get_crtc_state(state, &crtc->base); if …
Apr 22 2015
video: fbdev: tdfxfb: use arch_phys_wc_add() and ioremap_wc()
Author: Luis R. Rodriguez <mcgrof@suse.com> This driver uses the same area for MTRR as for the ioremap(). Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap’d area is requested as …
