Catégorie : Linux

HID: cypress: use swap() in cp_report_fixup()

Author: Fabian Frederick <fabf@skynet.be> Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick Signed-off-by: Jiri Kosina — drivers/hid/hid-cypress.c | 6 +—– 1 file changed, 1 insertion(+), 5 deletions(-)   diff –git a/drivers/hid/hid-cypress.c b/drivers/hid/hid-cypress.c index c4ef3bc..1b764d1 100644 — a/drivers/hid/hid-cypress.c +++ b/drivers/hid/hid-cypress.c @@ -41,13 +41,9 @@ static __u8 *cp_report_fixup(struct hid_device *hdev, …

Lire la suite

IB/mthca: use swap() in mthca_make_profile()

Author: Fabian Frederick <fabf@skynet.be> Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick Signed-off-by: Doug Ledford — drivers/infiniband/hw/mthca/mthca_profile.c | 8 ++—— 1 file changed, 2 insertions(+), 6 deletions(-)   diff –git a/drivers/infiniband/hw/mthca/mthca_profile.c b/drivers/infiniband/hw/mthca/mthca_profile.c index 8edb28a..15d0644 100644 — a/drivers/infiniband/hw/mthca/mthca_profile.c +++ b/drivers/infiniband/hw/mthca/mthca_profile.c @@ -77,7 +77,6 @@ s64 mthca_make_profile(struct mthca_dev *dev, u64 …

Lire la suite

mtd: cfi_cmdset_0002: use swap() in cfi_cmdset_0002()

Author: Fabian Frederick <fabf@skynet.be> Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick Signed-off-by: Brian Norris — drivers/mtd/chips/cfi_cmdset_0002.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-)   diff –git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index c3624eb..9dca881 100644 — a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -615,11 +615,9 @@ struct mtd_info *cfi_cmdset_0002(struct map_info *map, …

Lire la suite

mtd: ftl: use swap() in copy_erase_unit()

Author: Fabian Frederick <fabf@skynet.be> Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick Signed-off-by: Brian Norris — drivers/mtd/ftl.c | 8 ++—— 1 file changed, 2 insertions(+), 6 deletions(-)   diff –git a/drivers/mtd/ftl.c b/drivers/mtd/ftl.c index dabf084..9fb3b0d 100644 — a/drivers/mtd/ftl.c +++ b/drivers/mtd/ftl.c @@ -571,12 +571,8 @@ static int copy_erase_unit(partition_t *part, uint16_t …

Lire la suite

mmc: queue: use swap() in mmc_queue_thread()

Author: Fabian Frederick <fabf@skynet.be> Use kernel.h macro definition. Thanks to Julia Lawall for Coccinelle scripting support. Signed-off-by: Fabian Frederick Signed-off-by: Ulf Hansson — drivers/mmc/card/queue.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-)   diff –git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c index 8efa368..d34e09b 100644 — a/drivers/mmc/card/queue.c +++ b/drivers/mmc/card/queue.c @@ -56,7 +56,6 @@ static int mmc_queue_thread(void *d) down(&mq->thread_sem); …

Lire la suite

[media] s5p-tv: fix wait_event_timeout return handling

Author: Nicholas Mc Guire <hofrat@osadl.org> event API conformance testing with coccinelle spatches are being used to locate API usage inconsistencies this triggert with: ./drivers/media/platform/s5p-tv/mixer_reg.c:364 incorrect check for negative return Return type of wait_event_timeout is signed long not int and the return type is >=0 always thus the negative check is unnecessary. An appropriately named variable …

Lire la suite

[media] ddbridge: fix wait_event_timeout return handling

Author: Nicholas Mc Guire <hofrat@osadl.org> API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/media/pci/ddbridge/ddbridge-core.c:89 incorrect check for negative return Return type of wait_event_timeout is signed long not int and the return type is >=0 always thus the negative check is unnecessary.. As stat is used here exclusively …

Lire la suite

atm: idt77105: Use setup_timer

Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e1, e2, a; @@ -init_timer(&e1); +setup_timer(&e1, a, 0UL); … when != a = e2 -e1.function = a; Signed-off-by: Vaishali …

Lire la suite

Staging: vt6655: Remove unnecessary equality checks in rxtx.c

Author: Harisangam Sharvari <sharisan@visteon.com> The unnecessary equality checks for bool variable are removed in rxtx.c. These changes were detected with the help of coccinelle tool Signed-off-by: Harisangam Sharvari Signed-off-by: Greg Kroah-Hartman — drivers/staging/vt6655/rxtx.c | 8 ++++—- 1 file changed, 4 insertions(+), 4 deletions(-)   diff –git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 33c4aa4..534338c 100644 — a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c …

Lire la suite

atm: use msecs_to_jiffies for conversions

Author: Nicholas Mc Guire <hofrat@osadl.org> API compliance scanning with coccinelle flagged: ./drivers/atm/iphase.c:2621:4-20: WARNING: timeout (50) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent which does not seem intended. Fixed up by converting the constant to jiffies with msecs_to_jiffies() As this driver was introduced in the early 2.3 series it …

Lire la suite