Author: Axel Lin <axel.lin@ingics.com> This reverts 3d907cc30d07 (« ASoC: wm5100: Pass the IRQF_ONESHOT flag »). The coccinelle warnings is false positive because the original code does set IRQF_ONESHOT by « trigger |= IRQF_ONESHOT; ». Signed-off-by: Axel Lin Acked-by: Charles Keepax Signed-off-by: Mark Brown — sound/soc/codecs/wm5100.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-) diff –git a/sound/soc/codecs/wm5100.c …
Catégorie : Linux
Jul 02 2015
ASoC: wm0010: Remove spurious missing IRQF_ONESHOT
Author: Axel Lin <axel.lin@ingics.com> This reverts 58d468328646 (« ASoC: wm0010: Add missing IRQF_ONESHOT »). The coccinelle warnings is false positive because the original code does set IRQF_ONESHOT by « trigger |= IRQF_ONESHOT; ». Signed-off-by: Axel Lin Acked-by: Charles Keepax Signed-off-by: Mark Brown — sound/soc/codecs/wm0010.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c …
Jul 01 2015
backlight: lp8788_bl: Delete a check before backlight_device_unregister()
Author: Markus Elfring <elfring@users.sourceforge.net> The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Jingoo Han Signed-off-by: Lee Jones — drivers/video/backlight/lp8788_bl.c | 3 +– 1 file changed, 1 insertion(+), 2 …
Jul 01 2015
memstick: remove deprecated use of pci api
Author: Quentin Lambert <lambert.quentin@gmail.com> Replace occurences of the pci api by appropriate call to the dma api. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @deprecated@ idexpression id; position p; @@ ( pci_dma_supported@p ( id, …) | pci_alloc_consistent@p ( id, …) ) @bad1@ idexpression id; position deprecated.p; @@ …
Jun 30 2015
ARM: OMAP2: Delete an unnecessary check
Author: Markus Elfring <elfring@users.sourceforge.net> The of_node_put() function tests whether its argument is NULL and then returns immediately if so. Furthermore, the kerneldoc for of_node_put() explicitly supports passing in a NULL pointer as its argument. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring …
Jun 29 2015
iommu/arm-smmu: Delete an unnecessary check before the function call « free_io_pgtable_ops »
Author: Markus Elfring <elfring@users.sourceforge.net> The free_io_pgtable_ops() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Will Deacon Signed-off-by: Joerg Roedel — drivers/iommu/arm-smmu-v3.c | 3 +– 1 file changed, 1 insertion(+), 2 …
Jun 29 2015
staging:rtl8188eu: Code cleanup fix reported by coccinelle
Author: Prasanna Karthik <mkarthi3@visteon.com> bool check modified Signed-off-by: Prasanna Karthik Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8188eu/hal/rf_cfg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/staging/rtl8188eu/hal/rf_cfg.c b/drivers/staging/rtl8188eu/hal/rf_cfg.c index 455ecdc..954cade 100644 — a/drivers/staging/rtl8188eu/hal/rf_cfg.c +++ b/drivers/staging/rtl8188eu/hal/rf_cfg.c @@ -295,7 +295,7 @@ static bool rf6052_conf_para(struct adapter *adapt) break; } – if (rtstatus != true) + …
Jun 29 2015
staging:wilc1000: code cleanup Fix reported by coccinelle
Author: Prasanna Karthik <mkarthi3@visteon.com> Removed {} for single statement if block Signed-off-by: Prasanna Karthik Signed-off-by: Greg Kroah-Hartman — drivers/staging/wilc1000/fifo_buffer.c | 11 +++++—— 1 file changed, 5 insertions(+), 6 deletions(-) diff –git a/drivers/staging/wilc1000/fifo_buffer.c b/drivers/staging/wilc1000/fifo_buffer.c index b6c07cf..86eb82e 100644 — a/drivers/staging/wilc1000/fifo_buffer.c +++ b/drivers/staging/wilc1000/fifo_buffer.c @@ -31,11 +31,10 @@ u32 FIFO_DeInit(tHANDLE hFifo) u32 u32Error = 0; tstrFifoHandler *pstrFifoHandler = …
Jun 29 2015
net-Liquidio: Delete unnecessary checks before the function call « vfree »
Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: David S. Miller — drivers/net/ethernet/cavium/liquidio/octeon_device.c | 11 +++——– drivers/net/ethernet/cavium/liquidio/octeon_droq.c | 4 +— drivers/net/ethernet/cavium/liquidio/request_manager.c | 3 +– 3 files changed, 5 insertions(+), …
Jun 28 2015
PCI: iproc: Delete unnecessary checks before phy calls
Author: Markus Elfring <elfring@users.sourceforge.net> The functions phy_exit() and phy_power_off() test whether their argument is NULL and then return immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. [bhelgaas: also phy_init() and phy_power_on(), as Ray Jui suggested] [bhelgaas: also remove tests in iproc_pcie_remove()] Signed-off-by: Markus Elfring …