Author: Julia Lawall <julia@diku.dk> ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING and ME_IO_STREAM_CONFIG_WRAPAROUND both hanve 0 as the rightmost bit, and thus eg !flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING is always 0. I assume that !(flags & ME_IO_SINGLE_TYPE_WRITE_NONBLOCKING) and !(flags & ME_IO_STREAM_CONFIG_WRAPAROUND) were intended. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ expression E; constant C; @@ ( !E …
Catégorie : Coccinelle
Dec 24 2008
Staging: comedi: Correct use of ! and &
Author: Julia Lawall <julia@diku.dk> 0x20 has 0 as its rightmost bit and thus !inl(info->plx_regbase + PLX_INTCSR) & 0x20 is always 0. I assume that !(!inl(info->plx_regbase + PLX_INTCSR) & 0x20) was intended. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ expression E; constant C; @@ ( !E & !C | – …
Dec 23 2008
drivers/ide/{cs5530.c,sc1200.c}: Move a dereference below a NULL test
Author: Julia Lawall <julia@diku.dk> In each case, if the NULL test is necessary, then the dereference should be moved below the NULL test. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ type T; expression E; identifier i,fld; statement S; @@ – T i = E->fld; + T i; … when …
Dec 22 2008
[CIFS] Remove redundant test
Author: Julia Lawall <julia@diku.dk> In fs/cifs/cifssmb.c, pLockData is tested for being NULL at the beginning of the function, and not reassigned subsequently. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) Signed-off-by: Julia Lawall Signed-off-by: Steve French — fs/cifs/cifssmb.c | 4 —- 1 file changed, 4 deletions(-) diff …
Dec 21 2008
IB/ehca: Remove redundant test of vpage
Author: Julia Lawall <julia@diku.dk> vpage is checked not to be NULL just after it is initialized at the beginning of each loop iteration. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; expression E; position p1,p2; @@ if (x@p1 == NULL || …) …
Dec 21 2008
powerpc/85xx: Add local_irq_restore in error handling code
Author: Julia Lawall <julia@diku.dk> There is a call to local_irq_restore in the normal exit case, so it would seem that there should be one on an error return as well. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @@ expression l; expression E,E1,E2; @@ local_irq_save(l); … when != local_irq_restore(l) when != …
Dec 21 2008
USB: Remove redundant test in pxa27x_udc and ftdi_sio
Author: Julia Lawall <julia@diku.dk> priv is checked not to be NULL near the beginning of the function and not changed subsequently, making the test redundant. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; expression E; position p1,p2; @@ if (x@p1 == NULL …
Dec 21 2008
PCI hotplug: remove redundant test in cpq hotplug
Author: Julia Lawall <julia@diku.dk> func is checked not to be NULL a few lines before. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; expression E; position p1,p2; @@ if (x@p1 == NULL || …) { … when forall return …; } … …
Dec 21 2008
drivers/net/wan: Remove redundant test
Author: Julia Lawall <julia@diku.dk> arg is checked not to be NULL a few lines before. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; expression E; position p1,p2; @@ if (x@p1 == NULL || …) { … when forall return …; } … …
Dec 20 2008
fs/9p: change simple_strtol to simple_strtoul
Author: Julia Lawall <julia@diku.dk> Since v9ses->uid is unsigned, it would seem better to use simple_strtoul that simple_strtol. A simplified version of the semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r2@ long e; position p; @@ e = simple_strtol@p(…) @@ position p != r2.p; type T; T e; @@ e = – …
