Quentin LAMBERT
Articles de cet auteur
Sep 11 2013
Btrfs: add the missing mutex unlock in write_all_supers()
Author: Stefan Behrens <sbehrens@giantdisaster.de> The BUG() was replaced by btrfs_error() and return -EIO with the patch « get rid of one BUG() in write_all_supers() », but the missing mutex_unlock() was overlooked. The 0-DAY kernel build service from Intel reported the missing unlock which was found by the coccinelle tool: fs/btrfs/disk-io.c:3422:2-8: preceding lock on line 3374 Signed-off-by: Stefan …
Sep 04 2013
[media] dm1105: remove unneeded not-null test
Author: Alexandru Juncu <alexj@rosedu.org> i2c_adap is a field of a struct and will always be allocated so its address will never be null. Suggested by coccinelle, manually verified. Signed-off-by: Alexandru Juncu Signed-off-by: Mauro Carvalho Chehab — drivers/media/pci/dm1105/dm1105.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index e985e3b..e60ac35 100644 …
Sep 02 2013
drivers:net: delete premature free_irq
Author: Julia Lawall <Julia.Lawall@lip6.fr> Free_irq is not needed if there has been no request_irq. Free_irq is removed from both the probe and remove functions. The correct request_irq and free_irq are found in the open and close functions. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression …
Sep 02 2013
spi: designware: delete premature free_irq
Author: Julia Lawall <Julia.Lawall@lip6.fr> Free_irq is not needed if there has been no request_irq. Free_irq is removed from both the probe and remove functions. The correct request_irq and free_irq appear to be in the add_host and remove_host functions in spi-dw.c. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) …
Aug 29 2013
[SCSI] esas2r: coccinelle – Replace memcpy with struct assignment
Author: Bradley Grove <bgrove@attotech.com> Reported-by: Fengguang Wu Signed-off-by: Bradley Grove Signed-off-by: James Bottomley — drivers/scsi/esas2r/esas2r_flash.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-) diff –git a/drivers/scsi/esas2r/esas2r_flash.c b/drivers/scsi/esas2r/esas2r_flash.c index 45e353f..2ec3c23 100644 — a/drivers/scsi/esas2r/esas2r_flash.c +++ b/drivers/scsi/esas2r/esas2r_flash.c @@ -1360,7 +1360,7 @@ void esas2r_nvram_set_defaults(struct esas2r_adapter *a) u32 time = jiffies_to_msecs(jiffies); esas2r_lock_clear_flags(&a->flags, AF_NVR_VALID); – memcpy(n, &default_sas_nvram, …
Aug 26 2013
PCI: tegra: replace devm_request_and_ioremap by devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Use devm_ioremap_resource instead of devm_request_and_ioremap. This was done using the semantic patch scripts/coccinelle/api/devm_ioremap_resource.cocci Error-handling code was manually removed from the associated calls to platform_get_resource. Adjust the comment at the third platform_get_resource_byname to make clear why ioremap is not done at this point. Signed-off-by: Julia Lawall Acked-by: Thierry Reding Tested-by: Thierry Reding …
Aug 24 2013
spi: simplify devm_request_mem_region/devm_ioremap
Author: Julia Lawall <Julia.Lawall@lip6.fr> Convert the composition of devm_request_mem_region and devm_ioremap to a single call to devm_ioremap_resource. The associated call to platform_get_resource is also simplified and moved next to the new call to devm_ioremap_resource. This was done using a combination of the semantic patches devm_ioremap_resource.cocci and devm_request_and_ioremap.cocci, found in the scripts/coccinelle/api directory. This patch also …
Aug 20 2013
brcmsmac: use ARRAY_SIZE in phytbl_lcn.c
Author: Arend van Spriel <arend@broadcom.com> This patch converts all sizeof(x)/sizeof(x[0]) instances to ARRAY_SIZE macro in phytbl_lcn.c. The patch was made using spatch with ARRAY_SIZE.cocci (see [1]). [1] https://github.com/coccinelle/coccinelle/tree/master/demos/janitorings Cc: Jonas Gorski Tested-by: David Herrmann Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Signed-off-by: Arend van Spriel Signed-off-by: John W. Linville — …/wireless/brcm80211/brcmsmac/phy/phytbl_lcn.c | 117 ++++++++————- 1 file …
Aug 19 2013
usb: musb: dsps: fix devm_ioremap_resource error detection code
Author: Julia Lawall <Julia.Lawall@lip6.fr> devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. Furthermore, the value returned by devm_ioremap_resource should be tested. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(…); if (!e1) S // Signed-off-by: Julia Lawall Signed-off-by: …
Aug 19 2013
video: xilinxfb: replace devm_request_and_ioremap by devm_ioremap_resource
Author: Julia Lawall <Julia.Lawall@lip6.fr> Use devm_ioremap_resource instead of devm_request_and_ioremap. This was done using the semantic patch scripts/coccinelle/api/devm_ioremap_resource.cocci The initialization of drvdata->regs_phys was manually moved lower, to take advantage of the NULL test on res performed by devm_ioremap_resource. Signed-off-by: Julia Lawall Signed-off-by: Tomi Valkeinen — drivers/video/xilinxfb.c | 8 ++++—- 1 file changed, 4 insertions(+), 4 deletions(-) …