drivers/net/phy/mdio-bitbang.c: Call mdiobus_unregister before mdiobus_free

Author: Peter Senna Tschudin <peter.senna@gmail.com>

Based on commit b27393aecf66199f5ddad37c302d3e0cfadbe6c0

Calling mdiobus_free without calling mdiobus_unregister causes
BUG_ON(). This patch fixes the issue.

The semantic patch that found this issue(http://coccinelle.lip6.fr/):
// 
@@
expression E;
@@
  ... when != mdiobus_unregister(E);

+ mdiobus_unregister(E);
  mdiobus_free(E);
// 

Signed-off-by: Peter Senna Tschudin 
Signed-off-by: David S. Miller

---
 drivers/net/phy/mdio-bitbang.c | 1 +
 1 file changed, 1 insertion(+)
 
diff --git a/drivers/net/phy/mdio-bitbang.c b/drivers/net/phy/mdio-bitbang.c
index daec9b0..6428fcb 100644
--- a/drivers/net/phy/mdio-bitbang.c
+++ b/drivers/net/phy/mdio-bitbang.c
@@ -234,6 +234,7 @@ void free_mdio_bitbang(struct mii_bus *bus)
 	struct mdiobb_ctrl *ctrl = bus->priv;
 
 	module_put(ctrl->ops->owner);
+	mdiobus_unregister(bus);
 	mdiobus_free(bus);
 }
 EXPORT_SYMBOL(free_mdio_bitbang);

drivers/net/phy/mdio-bitbang.c: Call mdiobus_unregister before mdiobus_free

qlambert

Archives

Posts by Subject