ext4: use WARN in ext4_alloc_blocks

Author: Julia Lawall <Julia.Lawall@lip6.fr>

Use WARN rather than printk followed by WARN_ON(1), for conciseness.

A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)

// 
@@
expression list es;
@@

-printk(
+WARN(1,
  es);
-WARN_ON(1);
// 

Signed-off-by: Julia Lawall 
Signed-off-by: "Theodore Ts'o"

---
 fs/ext4/indirect.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
 
diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c
index bdd2023..1932810 100644
--- a/fs/ext4/indirect.c
+++ b/fs/ext4/indirect.c
@@ -358,9 +358,8 @@ static int ext4_alloc_blocks(handle_t *handle, struct inode *inode,
 			 * for the first direct block
 			 */
 			new_blocks[index] = current_block;
-			printk(KERN_INFO "%s returned more blocks than "
+			WARN(1, KERN_INFO "%s returned more blocks than "
 						"requested\n", __func__);
-			WARN_ON(1);
 			break;
 		}
 	}

ext4: use WARN in ext4_alloc_blocks

qlambert

Archives

Posts by Subject