Jan 21 2010

ceph: remove duplicate variable initialization 

Author: Julia Lawall <julia@diku.dk>

The variable client is initialized twice to the same (side effect-free)
expression.  Drop one initialization.

A simplified version of the semantic match that finds this problem is:
(http://coccinelle.lip6.fr/)

// 
@forall@
idexpression *x;
identifier f!=ERR_PTR;
@@

x = f(...)
... when != x
(
x = f(...,<+...x...+>,...)
|
* x = f(...)
)
// 

Signed-off-by: Julia Lawall 
Signed-off-by: Sage Weil 

---
 fs/ceph/addr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
 
diff --git a/fs/ceph/addr.c b/fs/ceph/addr.c
index a6850a1..a3bd9de 100644
--- a/fs/ceph/addr.c
+++ b/fs/ceph/addr.c
@@ -596,7 +596,7 @@ static int ceph_writepages_start(struct address_space *mapping,
 	struct inode *inode = mapping->host;
 	struct backing_dev_info *bdi = mapping->backing_dev_info;
 	struct ceph_inode_info *ci = ceph_inode(inode);
-	struct ceph_client *client = ceph_inode_to_client(inode);
+	struct ceph_client *client;
 	pgoff_t index, start, end;
 	int range_whole = 0;
 	int should_loop = 1;

qlambert