cciss: remove unneeded memset()

Author: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

The memory return by kzalloc() or kmem_cache_zalloc() has already be set
to zero, so remove useless memset(0).

spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)

Signed-off-by: Wei Yongjun 
Cc: Mike Miller 
Cc: Jens Axboe 
Cc: Stephen M. Cameron 
Signed-off-by: Andrew Morton 
Signed-off-by: Jens Axboe

---
 drivers/block/cciss.c | 1 -
 1 file changed, 1 deletion(-)
 
diff --git a/drivers/block/cciss.c b/drivers/block/cciss.c
index b0f553b..ca83f96 100644
--- a/drivers/block/cciss.c
+++ b/drivers/block/cciss.c
@@ -5205,7 +5205,6 @@ static void cciss_shutdown(struct pci_dev *pdev)
 		return;
 	}
 	/* write all data in the battery backed cache to disk */
-	memset(flush_buf, 0, 4);
 	return_code = sendcmd_withirq(h, CCISS_CACHE_FLUSH, flush_buf,
 		4, 0, CTLR_LUNID, TYPE_CMD);
 	kfree(flush_buf);

cciss: remove unneeded memset()

qlambert

Archives

Posts by Subject