Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_available_child_of_node performs an of_node_get on each iteration, so a return from the middle of the loop requires an of_node_put. A simplified version of the semantic patch that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_available_child_of_node(root, child) { … when != of_node_put(child) when != …
Category: Linux
Nov 16 2015
phy: miphy365x: add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_child_of_node performs an of_node_get on each iteration, so a return from the middle of the loop requires an of_node_put. A simplified version of the semantic patch that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { … when != of_node_put(child) when != …
Nov 16 2015
phy: miphy28lp: add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_child_of_node performs an of_node_get on each iteration, so a return from the middle of the loop requires an of_node_put. A simplified version of the semantic patch that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { … when != of_node_put(child) when != …
Nov 16 2015
phy: rockchip-usb: add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_available_child_of_node performs an of_node_get on each iteration, so a return from the middle of the loop requires an of_node_put. A simplified version of the semantic patch that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_available_child_of_node(root, child) { … when != of_node_put(child) when != …
Nov 16 2015
phy: berlin-sata: add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_available_child_of_node performs an of_node_get on each iteration, so a return from the middle of the loop requires an of_node_put. A simplified version of the semantic patch that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_available_child_of_node(root, child) { … when != of_node_put(child) when != …
Nov 16 2015
phy: mt65xx-usb3: add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_child_of_node performs an of_node_get on each iteration, so a return from the middle of the loop requires an of_node_put. A simplified version of the semantic patch that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_child_of_node(root, child) { … when != of_node_put(child) when != …
Nov 16 2015
phy: brcmstb-sata: add missing of_node_put
Author: Julia Lawall <Julia.Lawall@lip6.fr> for_each_available_child_of_node performs an of_node_get on each iteration, so a return from the middle of the loop requires an of_node_put. A simplified version of the semantic patch that finds this problem is as follows (http://coccinelle.lip6.fr): // @@ expression root,e; local idexpression child; @@ for_each_available_child_of_node(root, child) { … when != of_node_put(child) when != …
Nov 16 2015
sh: Delete unnecessary checks before the function call “mempool_destroy”
Author: Markus Elfring <elfring@users.sourceforge.net> The mempool_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Rich Felker — arch/sh/kernel/dwarf.c | 6 ++—- 1 file changed, 2 insertions(+), 4 deletions(-) diff …
Nov 15 2015
ACPI-EC: Drop unnecessary check made before calling acpi_ec_delete_query()
Author: Markus Elfring <elfring@users.sourceforge.net> The acpi_ec_delete_query() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring [ rjw: Subject ] Signed-off-by: Rafael J. Wysocki — drivers/acpi/ec.c | 2 +- 1 file changed, 1 …
Nov 15 2015
ide: constify ide_dma_ops structures
Author: Julia Lawall <julia.lawall@lip6.fr> The ide_dma_ops structures are never modified, so declare these as const, as is already done for the others. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: David S. Miller — drivers/ide/it821x.c | 2 +- drivers/ide/trm290.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff –git a/drivers/ide/it821x.c …