Author: Márton Németh <nm127@freemail.hu> From: Márton Németh The match_table field of the struct of_device_id is constant in so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { … const …
Category: Linux
Jan 16 2010
ecryptfs: Eliminate useless code
Author: Julia Lawall <julia@diku.dk> The variable lower_dentry is initialized twice to the same (side effect-free) expression. Drop one initialization. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // @forall@ idexpression *x; identifier f!=ERR_PTR; @@ x = f(…) … when != x ( x = f(…,,…) | * x = f(…) …
Jan 16 2010
USB: serial: Eliminate useless code
Author: Julia Lawall <julia@diku.dk> The variables priv and portdata are initialized twice to the same (side effect-free) expressions. Drop one initialization in each case. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // @forall@ idexpression *x; identifier f!=ERR_PTR; @@ x = f(…) … when != x ( x = f(…,,…) …
Jan 16 2010
Staging: go7007: Eliminate useless code
Author: Julia Lawall <julia@diku.dk> The variable s is initialized twice to the same (side effect-free) expression. Drop one initialization. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // @forall@ idexpression *x; identifier f!=ERR_PTR; @@ x = f(…) … when != x ( x = f(…,,…) | * x = f(…) …
Jan 12 2010
pcmcia: make Open Firmware device id constant
Author: Márton Németh <nm127@freemail.hu> The match_table field of the struct of_device_id is constant in so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; …
Jan 11 2010
drivers/block/drbd/drbd_receiver.c: correct NULL test
Author: Julia Lawall <julia@diku.dk> Test the just-allocated value for NULL rather than some other value. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,y; statement S; @@ x = \(kmalloc\|kcalloc\|kzalloc\)(…); ( if ((x) == NULL) S | if ( – y + x == NULL) S ) // Signed-off-by: …
Jan 10 2010
hwmon: Make PCI device ids constant
Author: Márton Németh <nm127@freemail.hu> The id_table field of the struct pci_driver is constant in so it is worth to make pci_device_id also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; … }; @s@ identifier …
Jan 10 2010
HID: make USB device id constant
Author: Márton Németh <nm127@freemail.hu> The id_table field of the struct usb_device_id is constant in so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; …
Jan 10 2010
acpi: make ACPI device id constant
Author: Márton Németh <nm127@freemail.hu> The ids field of the struct acpi_driver is constant in so it is worth to make the initialization data also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; …
Jan 10 2010
USB goku_udc: make PCI device id constant
Author: Németh Márton <nm127@freemail.hu> The id_table field of the struct pci_driver is constant in so it is worth to make pci_ids also constant. The semantic match that finds this kind of pattern is as follows: (http://coccinelle.lip6.fr/) // @r@ disable decl_init,const_decl_init; identifier I1, I2, x; @@ struct I1 { … const struct I2 *x; … }; …