Author: Julia Lawall <julia@diku.dk> Error handling code following a kmalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,f1,l; position p1,p2; expression *ptr != NULL; @@ x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(…); … if (x == NULL) S f1 …
Category: Linux
Mar 30 2011
sh: Fix irq cleanup fallout
Author: Thomas Gleixner <tglx@linutronix.de> I missed that coccinelle does not fix up header files by default. Reported-by: Rafael J. Wysocki Signed-off-by: Thomas Gleixner Cc: Paul Mundt Cc: — drivers/sh/intc/internals.h | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-) diff –git a/drivers/sh/intc/internals.h b/drivers/sh/intc/internals.h index df36a42..5b93485 100644 — a/drivers/sh/intc/internals.h +++ b/drivers/sh/intc/internals.h @@ -86,7 +86,7 @@ …
Mar 30 2011
x86: apb_timer: Fixup genirq fallout
Author: Thomas Gleixner <tglx@linutronix.de> The lonely user of the internal interface was not in the coccinelle script. Reported-by: Randy Dunlap Signed-off-by: Thomas Gleixner — arch/x86/kernel/apb_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/arch/x86/kernel/apb_timer.c b/arch/x86/kernel/apb_timer.c index 1293c70..cd1ffed 100644 — a/arch/x86/kernel/apb_timer.c +++ b/arch/x86/kernel/apb_timer.c @@ -316,7 +316,7 @@ static void apbt_setup_irq(struct apbt_dev …
Mar 29 2011
FRV: Convert genirq namespace
Author: Thomas Gleixner <tglx@linutronix.de> Convert to new function names. Converted with coccinelle. Signed-off-by: Thomas Gleixner Signed-off-by: David Howells — arch/frv/kernel/irq-mb93091.c | 4 ++– arch/frv/kernel/irq-mb93093.c | 2 +- arch/frv/kernel/irq-mb93493.c | 3 ++- arch/frv/kernel/irq.c | 4 ++– 4 files changed, 7 insertions(+), 6 deletions(-) diff –git a/arch/frv/kernel/irq-mb93091.c b/arch/frv/kernel/irq-mb93091.c index f007aaf..9afc2ea 100644 — a/arch/frv/kernel/irq-mb93091.c +++ b/arch/frv/kernel/irq-mb93091.c @@ …
Mar 28 2011
drivers: Final irq namespace conversion
Author: Thomas Gleixner <tglx@linutronix.de> Scripted with coccinelle. Signed-off-by: Thomas Gleixner — drivers/ata/pata_ixp4xx_cf.c | 2 +- drivers/ata/pata_rb532_cf.c | 4 ++– drivers/hwmon/gpio-fan.c | 2 +- drivers/input/keyboard/lm8323.c | 4 ++– drivers/input/serio/ams_delta_serio.c | 2 +- drivers/input/touchscreen/mainstone-wm97xx.c | 2 +- drivers/input/touchscreen/zylonite-wm97xx.c | 2 +- drivers/misc/sgi-gru/grufile.c | 2 +- drivers/mmc/host/sdhci-spear.c | 2 +- drivers/net/dm9000.c | 8 ++++—- drivers/net/wireless/p54/p54spi.c | 3 +– …
Mar 28 2011
m68k: Convert irq function namespace
Author: Thomas Gleixner <tglx@linutronix.de> Scripted with coccinelle. Signed-off-by: Thomas Gleixner — arch/m68k/kernel/irq.c | 2 +- arch/m68k/platform/5249/intc2.c | 4 ++– arch/m68k/platform/5272/intc.c | 12 ++++++—— arch/m68k/platform/68328/ints.c | 4 ++– arch/m68k/platform/68360/ints.c | 4 ++– arch/m68k/platform/coldfire/intc-2.c | 10 +++++—– arch/m68k/platform/coldfire/intc-simr.c | 10 +++++—– arch/m68k/platform/coldfire/intc.c | 6 +++— 8 files changed, 26 insertions(+), 26 deletions(-) diff –git a/arch/m68k/kernel/irq.c b/arch/m68k/kernel/irq.c …
Mar 27 2011
MIPS: Convert the irq functions to the new names
Author: Thomas Gleixner <tglx@linutronix.de> Scripted with coccinelle. Signed-off-by: Thomas Gleixner — arch/mips/alchemy/devboards/bcsr.c | 6 +– arch/mips/alchemy/devboards/db1200/setup.c | 2 +- arch/mips/alchemy/devboards/db1x00/board_setup.c | 50 ++++++++++++———— arch/mips/alchemy/devboards/pb1000/board_setup.c | 2 +- arch/mips/alchemy/devboards/pb1100/board_setup.c | 8 ++– arch/mips/alchemy/devboards/pb1200/board_setup.c | 2 +- arch/mips/alchemy/devboards/pb1500/board_setup.c | 16 ++++—- arch/mips/alchemy/devboards/pb1550/board_setup.c | 6 +– arch/mips/alchemy/mtx-1/board_setup.c | 10 ++— arch/mips/alchemy/xxs1500/board_setup.c | 24 ++++++—— arch/mips/ar7/irq.c | 4 +- …
Mar 25 2011
alpha: Convert to new irq function names
Author: Thomas Gleixner <tglx@linutronix.de> Scripted with coccinelle. Signed-off-by: Thomas Gleixner — arch/alpha/kernel/irq.c | 2 +- arch/alpha/kernel/irq_alpha.c | 2 +- arch/alpha/kernel/irq_i8259.c | 2 +- arch/alpha/kernel/irq_pyxis.c | 2 +- arch/alpha/kernel/irq_srm.c | 2 +- arch/alpha/kernel/sys_alcor.c | 2 +- arch/alpha/kernel/sys_cabriolet.c | 4 ++– arch/alpha/kernel/sys_dp264.c | 2 +- arch/alpha/kernel/sys_eb64p.c | 2 +- arch/alpha/kernel/sys_eiger.c | 2 +- arch/alpha/kernel/sys_jensen.c | 10 +++++—– …
Mar 25 2011
ia64: Convert to the new irq_* function names
Author: Thomas Gleixner <tglx@linutronix.de> Scripted with coccinelle. Signed-off-by: Thomas Gleixner — arch/ia64/hp/sim/hpsim_irq.c | 4 ++– arch/ia64/kernel/irq_ia64.c | 4 ++– arch/ia64/kernel/msi_ia64.c | 8 ++++—- arch/ia64/sn/kernel/msi_sn.c | 4 ++– 4 files changed, 10 insertions(+), 10 deletions(-) diff –git a/arch/ia64/hp/sim/hpsim_irq.c b/arch/ia64/hp/sim/hpsim_irq.c index d7a3c46..4bd9a63 100644 — a/arch/ia64/hp/sim/hpsim_irq.c +++ b/arch/ia64/hp/sim/hpsim_irq.c @@ -43,9 +43,9 @@ hpsim_irq_init (void) int i; …
Mar 25 2011
powerpc: Convert to new irq_* function names
Author: Thomas Gleixner <tglx@linutronix.de> Scripted with coccinelle. Signed-off-by: Thomas Gleixner — arch/powerpc/kernel/irq.c | 6 +++— arch/powerpc/kernel/machine_kexec.c | 2 +- arch/powerpc/kernel/pci-common.c | 2 +- arch/powerpc/platforms/512x/mpc5121_ads_cpld.c | 4 ++– arch/powerpc/platforms/52xx/media5200.c | 10 +++++—– arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 10 +++++—– arch/powerpc/platforms/52xx/mpc52xx_pic.c | 6 +++— arch/powerpc/platforms/82xx/pq2ads-pci-pic.c | 14 +++++++——- arch/powerpc/platforms/85xx/ksi8560.c | 4 ++– arch/powerpc/platforms/85xx/mpc85xx_ads.c | 4 ++– arch/powerpc/platforms/85xx/mpc85xx_cds.c | 2 +- …