Category: Linux

tpm: Create a tpm_class_ops structure and use it in the drivers

Author: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> This replaces the static initialization of a tpm_vendor_specific structure in the drivers with the standard Linux idiom of providing a const structure of function pointers. Signed-off-by: Jason Gunthorpe Reviewed-by: Joel Schopp Reviewed-by: Ashley Lai [phuewe: did apply manually due to commit 191ffc6bde3 tpm/tpm_i2c_atmel: fix coccinelle warnings] Signed-off-by: Peter Huewe — drivers/char/tpm/tpm-interface.c …

Continue reading

tpm: Pull all driver sysfs code into tpm-sysfs.c

Author: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> The tpm core now sets up and controls all sysfs attributes, instead of having each driver have a unique take on it. All drivers now now have a uniform set of attributes, and no sysfs related entry points are exported from the tpm core module. This also uses the new method …

Continue reading

staging/lustre: remove CFS_MODULE_PARM

Author: Peng Tao <bergwolf@gmail.com> Patch generated by coccinelle: @generic_type@ declarer name CFS_MODULE_PARM; declarer name module_param; declarer name MODULE_PARM_DESC; expression E1, E2, E3, E4; type t; @@ -CFS_MODULE_PARM(E1, E2, t, E3, E4); +module_param(E1, t, E3); +MODULE_PARM_DESC(E1, E4); @charp@ expression E1, E2, E3, E4, E5; @@ -CFS_MODULE_PARM(E1, E2, E3, E4, E5); +module_param(E1, E3, E4); +MODULE_PARM_DESC(E1, E5); With …

Continue reading

drivers/rtc/rtc-ds1307.c: change variable type to bool

Author: Peter Senna Tschudin <peter.senna@gmail.com> The variable want_irq is only assigned the values true and false. Change its type to bool. The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/): @exists@ type T; identifier b; @@ – T + bool b = …; … when any b = \(true\|false\) Signed-off-by: Peter Senna …

Continue reading

cfg80211: move regulatory flags to their own variable

Author: Luis R. Rodriguez <mcgrof@do-not-panic.com> We’ll expand this later, this will make it easier to classify and review what things are related to regulatory or not. Coccinelle only missed 4 hits, which I had to do manually, supplying the SmPL in case of merge conflicts. @@ struct wiphy *wiphy; @@ -wiphy->flags |= WIPHY_FLAG_CUSTOM_REGULATORY +wiphy->regulatory_flags |= …

Continue reading

staging: vt6655: delete explicit comparison to bool

Author: Teodora Baluta <teobaluta@gmail.com> This patch fixes all bool tests by deleting the comparison. Most of these were detected using coccinelle and silence the following type of coccinelle warnings for drivers/staging/vt6655/bssdb.c file: WARNING: Comparison to bool Signed-off-by: Teodora Baluta Reviewed-by: Peter P Waskiewicz Jr Signed-off-by: Greg Kroah-Hartman — drivers/staging/vt6655/bssdb.c | 50 ++++++++++++++++++++———————- 1 file changed, …

Continue reading

Input: cyttsp4 – replace IS_ERR and PTR_ERR with PTR_ERR_OR_ZERO

Author: Duan Jiong <duanj.fnst@cn.fujitsu.com> This patch fixes coccinelle error regarding usage of IS_ERR and PTR_ERR instead of PTR_ERR_OR_ZERO. Signed-off-by: Duan Jiong Signed-off-by: Dmitry Torokhov — drivers/input/touchscreen/cyttsp4_spi.c | 5 +—- 1 file changed, 1 insertion(+), 4 deletions(-)   diff –git a/drivers/input/touchscreen/cyttsp4_spi.c b/drivers/input/touchscreen/cyttsp4_spi.c index a71e114..b19434c 100644 — a/drivers/input/touchscreen/cyttsp4_spi.c +++ b/drivers/input/touchscreen/cyttsp4_spi.c @@ -171,10 +171,7 @@ static int cyttsp4_spi_probe(struct …

Continue reading

staging: vt6655: remove unneeded semicolon

Author: Teodora Baluta <teobaluta@gmail.com> This patch deletes any unneeded semicolons in driver vt6655 as detected by coccinelle. Signed-off-by: Teodora Baluta Signed-off-by: Greg Kroah-Hartman — drivers/staging/vt6655/bssdb.c | 2 +- drivers/staging/vt6655/card.c | 2 +- drivers/staging/vt6655/dpc.c | 6 +++— drivers/staging/vt6655/iwctl.c | 2 +- drivers/staging/vt6655/power.c | 2 +- drivers/staging/vt6655/rxtx.c | 4 ++– drivers/staging/vt6655/wmgr.c | 12 ++++++—— 7 files changed, …

Continue reading

staging: vt6655: fix comparison of bool to 0/1

Author: Teodora Baluta <teobaluta@gmail.com> This patch corrects comparison of bool to 0/1 for file drivers/staging/vt6655/rxtx.c. The following type of coccinelle detected warnings are silenced: WARNING: Comparison of bool to 0/1 Signed-off-by: Teodora Baluta Signed-off-by: Greg Kroah-Hartman — drivers/staging/vt6655/rxtx.c | 8 ++++—- 1 file changed, 4 insertions(+), 4 deletions(-)   diff –git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 3a2661e..182c53e …

Continue reading

staging: vt6655: fix assignment of bool to 0

Author: Teodora Baluta <teobaluta@gmail.com> This patch fixes the following warnings detected using coccinelle for drivers/staging/wmgr.c file: drivers/staging/vt6655/wmgr.c:2335:1-22: WARNING: Assignment of bool to 0/1 drivers/staging/vt6655/wmgr.c:2338:1-27: WARNING: Assignment of bool to 0/1 Signed-off-by: Teodora Baluta Signed-off-by: Greg Kroah-Hartman — drivers/staging/vt6655/wmgr.c | 4 ++– 1 file changed, 2 insertions(+), 2 deletions(-)   diff –git a/drivers/staging/vt6655/wmgr.c b/drivers/staging/vt6655/wmgr.c index 40bb900..a1eff7e …

Continue reading