Author: Markus Elfring <elfring@users.sourceforge.net> The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Jarkko Nikula Signed-off-by: Mark Brown — sound/soc/omap/mcbsp.c | 3 +– 1 file changed, 1 insertion(+), 2 …
Category: Linux
Nov 17 2014
ALSA: powermac: Deletion of an unnecessary check before the function call “pci_dev_put”
Author: Markus Elfring <elfring@users.sourceforge.net> The pci_dev_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/ppc/pmac.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Nov 17 2014
ALSA: hdsp: Deletion of an unnecessary check before the function call “release_firmware”
Author: Markus Elfring <elfring@users.sourceforge.net> The release_firmware() function tests whether its argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/pci/rme9652/hdsp.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Nov 17 2014
ALSA: lola: Deletion of an unnecessary check before the function call “vfree”
Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/pci/lola/lola_mixer.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff –git a/sound/pci/lola/lola_mixer.c b/sound/pci/lola/lola_mixer.c index 782f4d8..e7fe15d …
Nov 17 2014
ALSA: ice17xx: Deletion of unnecessary checks before the function call “snd_ac97_resume”
Author: Markus Elfring <elfring@users.sourceforge.net> The snd_ac97_resume() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/pci/ice1712/ice1712.c | 3 +– sound/pci/ice1712/ice1724.c | 3 +– 2 files changed, 2 insertions(+), …
Nov 17 2014
ALSA: hda: Deletion of unnecessary checks before two function calls
Author: Markus Elfring <elfring@users.sourceforge.net> The functions kfree() and release_firmware() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/pci/hda/hda_codec.c | 3 +– sound/pci/hda/hda_intel.c | 3 +– 2 files changed, …
Nov 17 2014
Thermal: fix platform_no_drv_owner.cocci warnings
Author: Wu Fengguang <fengguang.wu@intel.com> drivers/thermal/int340x_thermal/int3403_thermal.c:468:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu Acked-by: Zhang Rui Signed-off-by: Zhang Rui — drivers/thermal/int340x_thermal/int3403_thermal.c | 1 – 1 file changed, 1 deletion(-) diff –git a/drivers/thermal/int340x_thermal/int3403_thermal.c b/drivers/thermal/int340x_thermal/int3403_thermal.c index …
Nov 17 2014
jbd: Deletion of an unnecessary check before the function call “iput”
Author: Markus Elfring <elfring@users.sourceforge.net> The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Jan Kara — fs/jbd/journal.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Nov 16 2014
tracing: Deletion of an unnecessary check before iput()
Author: Markus Elfring <elfring@users.sourceforge.net> The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Link: http://lkml.kernel.org/r/5468F875.7080907@users.sourceforge.net Signed-off-by: Markus Elfring Signed-off-by: Steven Rostedt — kernel/trace/trace_uprobe.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) …
Nov 16 2014
PM / hibernate: Deletion of an unnecessary check before the function call “vfree”
Author: Markus Elfring <elfring@users.sourceforge.net> The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Rafael J. Wysocki — kernel/power/swap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/kernel/power/swap.c b/kernel/power/swap.c index …
