Author: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com> This patch focuses on fixing the following warning generated by checkpatch.pl for the file rxtx.c Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) @@ expression e1, e2; @@ – memcpy(e1, e2, ETH_ALEN); + ether_addr_copy(e1, e2); struct _adapter { struct dvobj_priv dvobjpriv; /* 0 40*/ struct mlme_priv mlmepriv; /* 40 …
Category: Linux
Feb 22 2015
KVM: MIPS: Enable after disabling interrupt
Author: Tapasweni Pathak <tapaswenipathak@gmail.com> Enable disabled interrupt, on unsuccessful operation. Found by Coccinelle. Signed-off-by: Tapasweni Pathak Acked-by: Julia Lawall Reviewed-by: James Hogan Signed-off-by: Marcelo Tosatti — arch/mips/kvm/tlb.c | 1 + 1 file changed, 1 insertion(+) diff –git a/arch/mips/kvm/tlb.c b/arch/mips/kvm/tlb.c index bbcd822..b6beb0e 100644 — a/arch/mips/kvm/tlb.c +++ b/arch/mips/kvm/tlb.c @@ -216,6 +216,7 @@ int kvm_mips_host_tlb_write(struct kvm_vcpu *vcpu, …
Feb 22 2015
Staging: rtl8192e: replace memcpy() by ether_addr_copy() using coccinelle and pack variable
Author: Melike Yurtoglu <aysemelikeyurtoglu@gmail.com> This patch focuses on fixing the following warning generated by checkpatch.pl for the file rxtx.c Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) @@ expression e1, e2; @@ – memcpy(e1, e2, ETH_ALEN); + ether_addr_copy(e1, e2); struct net_device { char name[16]; /* 0 16*/ struct hlist_node name_hlist; /* 16 16*/ …
Feb 22 2015
Staging: vt6656: replace memcpy() by ether_addr_copy() using coccinelle and pack variable
Author: aybuke ozdemir <aybuke.147@gmail.com> This patch focuses on fixing the following warning generated by checkpatch.pl for the file rxtx.c Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) @@ expression e1, e2; @@ – memcpy(e1, e2, ETH_ALEN); + ether_addr_copy(e1, e2); According to ether_addr_copy() description and functionality, all Ethernet addresses should align to the u16 …
Feb 20 2015
staging: emxx_udc: Replace GFP_KERNEL with GFP_ATOMIC
Author: Tapasweni Pathak <tapaswenipathak@gmail.com> To avoid deadlock, do not call blocking functions with spinlocks held. Replace GFP_KERNEL with GFP_ATOMIC, as the latter will fail if the pile doesn’t have enough free pages but will not sleep and hence deadlock can be avoided. Found by Coccinelle. Signed-off-by: Tapasweni Pathak Signed-off-by: Greg Kroah-Hartman — drivers/staging/emxx_udc/emxx_udc.c | 2 …
Feb 20 2015
dmaengine: jz4740: Remove extra check
Author: Tapasweni Pathak <tapaswenipathak@gmail.com> Remove double check on chan->desc. Found by Coccinelle. Signed-off-by: Tapasweni Pathak Acked-by: Julia Lawall Signed-off-by: Vinod Koul — drivers/dma/dma-jz4740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/dma/dma-jz4740.c b/drivers/dma/dma-jz4740.c index 4527a3e..f6a4c42 100644 — a/drivers/dma/dma-jz4740.c +++ b/drivers/dma/dma-jz4740.c @@ -343,7 +343,7 @@ static void jz4740_dma_chan_irq(struct jz4740_dmaengine_chan *chan) { …
Feb 20 2015
Staging: rtl8723au: Use put_unaligned_le16
Author: Vaishali Thakkar <vthakkar1994@gmail.com> Using byte ordering functions and then memcpy() is risky and prone to hide errors which are hard to track down. So, this patch introduces the use of function put_unaligned_le16 which makes the code clear. Here, use of variable tim_bitmap_le and variable itself is removed. Also, to be compatible with the changes …
Feb 20 2015
Staging: rtl8188eu: Use put_unaligned_le16
Author: Vaishali Thakkar <vthakkar1994@gmail.com> Using byte ordering functions and then memcpy() is risky and prone to hide errors which are hard to track down. So, this patch introduces the use of function put_unaligned_le16 which makes the code clear. Here, use of variable tim_bitmap_le and variable itself is removed. Also, to be compatible with the changes …
Feb 19 2015
staging: comedi: drivers: replace init_timer by setup_timer
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch replaces init_timer and 2 step initialization of function and data by setup_timer to make the code more concise. The issue was discovered using the following coccinelle script: @@ expression ds, e1, e2; @@ -init_timer (&ds); +setup_timer (&ds, e1, e2); … -ds.function = e1; … -ds.data = e2; Acked-by: Julia …
Feb 19 2015
staging: unisys: Remove unnecessary OOM message
Author: Quentin Lambert <lambert.quentin@gmail.com> This patch reduces the kernel size by removing error messages that duplicate the normal OOM message. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @@ identifier f,print,l; expression e; constant char[] c; @@ e = \(kzalloc\|kmalloc\|devm_kzalloc\|devm_kmalloc\)(…); if (e == NULL) { } Signed-off-by: Quentin …