Category: Linux

drm/i915: Kill intel_crtc->cursor_{width, height} (v2)

Author: Matt Roper <matthew.d.roper@intel.com> The cursor size fields in intel_crtc just duplicate the data from cursor->state.crtc_{w,h} so we don’t need them any more. Worse, their use in the watermark code actually introduces a subtle bug since they don’t get updated to mirror the state values until the plane commit stage, which is *after* we’ve already …

Continue reading

net: smc91c92_cs: Use setup_timer and mod_timer

Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use timer API functions setup_timer and mod_timer instead of structure assignments as they are standard way to set the timer and to update the expire field of an active timer respectively. This is done using Coccinelle and semantic patch used for this is as follows: // @@ expression x,y,z,a,b; @@ -init_timer …

Continue reading

Staging: rtl8712: Eliminate use of _set_timer

Author: Vaishali Thakkar <vthakkar1994@gmail.com> This patch introduces the use of API function mod_timer instead of driver specific function _set_timer as it is a more efficient and standard way to update the expire field of an active timer. Also, definition of function _set_timer is removed as it is no longer needed after this change. Here, these …

Continue reading

staging: gdm72xx: Condense two statements into one to improve code readability.

Author: Navya Sri Nizamkari <navyasri.tech@gmail.com> This patch removes a variable assignmnet to a value, used only for returning that value. The following coccinelle script was used to discover it: @@ expression ret; identifier f; @@ -ret = +return f(…); -return ret; Signed-off-by: Navya Sri Nizamkari Signed-off-by: Greg Kroah-Hartman — drivers/staging/gdm72xx/gdm_qos.c | 3 +– 1 file …

Continue reading

staging: dgap: remove unused variable

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; … when != len when strict -len = +return f(…); -return len; Signed-off-by: …

Continue reading

staging: fbtft: remove unused variable

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; … when != len when strict -len = +return f(…); -return len; Signed-off-by: …

Continue reading

staging: iio: light: remove unused variable

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; … when != len when strict -len = +return f(…); -return len; Signed-off-by: …

Continue reading

staging: iio: meter: remove unused variable

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; … when != len when strict -len = +return f(…); -return len; Signed-off-by: …

Continue reading

staging: lustre: llite: remove unused variable

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; … when != len when strict -len = +return f(…); -return len; Signed-off-by: …

Continue reading

staging: lustre: llite: remove unused variable

Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> This patch removes a variable that was simply used to store the return value of a function call before returning it. The issue was detected and resolved using the following coccinelle script: @@ identifier len,f; @@ -int len; … when != len when strict -len = +return f(…); -return len; Signed-off-by: …

Continue reading