Category: Linux

net: mv643xx_eth: Use setup_timer

Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e, func, da; @@ -init_timer (&e); +setup_timer (&e, func, da); -e.data = da; -e.function = func; Signed-off-by: Vaishali Thakkar …

Continue reading

isdn/capi: Use setup_timer

Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e1, e2, e3, e4, a, b; @@ -init_timer(&e1); +setup_timer(&e1, a, b); … when != a = e2 when != …

Continue reading

USB: serial: mos7840: Use setup_timer

Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e1, e2, e3, e4, a, b; @@ -init_timer(&e1); +setup_timer(&e1, a, b); … when != a = e2 when != …

Continue reading

video: fbdev: gbefb: use arch_phys_wc_add() and devm_ioremap_wc()

Author: Luis R. Rodriguez <mcgrof@suse.com> Convert the driver from using the x86 specific MTRR code to the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add() will avoid MTRR if write-combining is available, in order to take advantage of that also ensure the ioremap’d area is requested as write-combining. There are a few motivations for this: a) Take advantage of …

Continue reading

staging: panel: use schedule_timeout_interruptible()

Author: Nicholas Mc Guire <hofrat@osadl.org> API consolidation with coccinelle found: ./drivers/staging/panel/panel.c:782:2-18: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to the schedule_timeout_interruptible() helper only – so only an API consolidation to improve readability. The timeout was being passed as (ms * HZ + 999) / 1000 but that simply looks …

Continue reading

staging: me_daq: use schedule_timeout_interruptible()

Author: Nicholas Mc Guire <hofrat@osadl.org> API consolidation with coccinelle found: ./drivers/staging/comedi/drivers/me_daq.c:177:1-17: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion of the current calls to an available helper only – so only an API consolidation to improve readability. Signed-off-by: Nicholas Mc Guire Reviewed-by: Ian Abbott Signed-off-by: Greg Kroah-Hartman — drivers/staging/comedi/drivers/me_daq.c | 3 +– 1 file …

Continue reading

staging: unisys: use schedule_timeout_interruptible()

Author: Nicholas Mc Guire <hofrat@osadl.org> API consolidation with coccinelle found: ./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion with respect to schedule_timeout() to the schedule_timeout_interruptible() helper only – so only an API consolidation to improve readability. The hard coded timeout of 10 jiffies is HZ dependent which it should not be, so it …

Continue reading

sound/oss: use schedule_timeout_interruptible()

Author: Nicholas Mc Guire <hofrat@osadl.org> API consolidation with coccinelle found: ./sound/oss/msnd_pinnacle.c:1292:2-18: consolidation with schedule_timeout_*() recommended This is a 1:1 conversion of the current calls to an available helper only – so only an API consolidation to improve readability. Patch was compile tested with x86_64_defconfig Patch is against 4.1-rc5 (localversion-next is -next-20150529) Signed-off-by: Nicholas Mc Guire …

Continue reading

regmap: drop unneeded goto

Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier l; @@ -if (…) goto l; -l: // Signed-off-by: Julia Lawall Signed-off-by: Mark Brown — drivers/base/regmap/regmap.c | …

Continue reading

staging/lustre/mdc: drop unneeded goto

Author: Julia Lawall <Julia.Lawall@lip6.fr> Delete jump to a label on the next line, when that label is not used elsewhere. A simplified version of the semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @r@ identifier l; @@ -if (…) goto l; -l: // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/mdc/mdc_request.c | …

Continue reading