Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Replace if condition and BUG() with a BUG_ON having the conditional expression of the if statement as argument. The Coccinelle semantic patch used to make this change is as follows: @@ expression E,f; @@ ( if () { BUG(); } | – if (E) { BUG(); } + BUG_ON(E); ) …
Category: Linux
May 28 2016
mtd: Replace if and BUG with BUG_ON
Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Replace if condition and BUG() with a BUG_ON having the conditional expression of the if statement as argument. The Coccinelle semantic patch used to make this change is as follows: @@ expression E,f; @@ ( if () { BUG(); } | – if (E) { BUG(); } + BUG_ON(E); ) …
May 28 2016
um: Eliminate null test after alloc_bootmem
Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> alloc_bootmem function never returns NULL. Thus a NULL test after a call to this function is unnecessary. The Coccinelle semantic patch used to make this change is follows: @@ expression E; statement S; @@ E = alloc_bootmem(…) … when != E – if (E == NULL) S Signed-off-by: Amitoj Kaur …
May 25 2016
ASoC: ak4613: Remove owner assignment from platform_driver
Author: Fabio Estevam <fabio.estevam@nxp.com> This platform_driver does not need to set an owner as it will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Signed-off-by: Fabio Estevam Signed-off-by: Mark Brown — sound/soc/codecs/ak4613.c | 1 – 1 file changed, 1 deletion(-) diff –git a/sound/soc/codecs/ak4613.c b/sound/soc/codecs/ak4613.c index 647f69d..33d2f2e1 100644 — a/sound/soc/codecs/ak4613.c +++ b/sound/soc/codecs/ak4613.c @@ -530,7 …
May 25 2016
ASoC: pcm5102a: Remove owner assignment from platform_driver
Author: Fabio Estevam <fabio.estevam@nxp.com> This platform_driver does not need to set an owner as it will be populated by the driver core. Generated by scripts/coccinelle/api/platform_no_drv_owner.cocci. Signed-off-by: Fabio Estevam Signed-off-by: Mark Brown — sound/soc/codecs/pcm5102a.c | 1 – 1 file changed, 1 deletion(-) diff –git a/sound/soc/codecs/pcm5102a.c b/sound/soc/codecs/pcm5102a.c index ed51567..8ba322a 100644 — a/sound/soc/codecs/pcm5102a.c +++ b/sound/soc/codecs/pcm5102a.c @@ -57,7 …
May 24 2016
spi: spi-ep93xx: Fix the PTR_ERR() argument
Author: Fabio Estevam <fabio.estevam@nxp.com> PTR_ERR should access the value just tested by IS_ERR. The semantic patch that makes this change is available in scripts/coccinelle/tests/odd_ptr_err.cocci. Signed-off-by: Fabio Estevam Signed-off-by: Mark Brown — drivers/spi/spi-ep93xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/spi/spi-ep93xx.c b/drivers/spi/spi-ep93xx.c index bb00be8..17a6387 100644 — a/drivers/spi/spi-ep93xx.c +++ b/drivers/spi/spi-ep93xx.c @@ …
May 24 2016
nilfs2: constify nilfs_sc_operations structures
Author: Julia Lawall <Julia.Lawall@lip6.fr> The nilfs_sc_operations structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Signed-off-by: Ryusuke Konishi Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds — fs/nilfs2/segment.c | 10 +++++—– 1 file changed, 5 insertions(+), 5 deletions(-) diff –git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index 4317f72..483e663 100644 — a/fs/nilfs2/segment.c …
May 21 2016
checkpatch: whine about ACCESS_ONCE
Author: Joe Perches <joe@perches.com> Add a test for use of ACCESS_ONCE that could be written using READ_ONCE or WRITE_ONCE. –fix it too if desired. The WRITE_ONCE fixes are less correct than the coccinelle script below as checkpatch cannot have a completely correct “expression” mechanism because checkpatch works on patches and not complete files. $ cat …
May 17 2016
iio: Export I2C module alias information
Author: Javier Martinez Canillas <javier@osg.samsung.com> The I2C drivers have an i2c_device_id array but that information isn’t exported to the modules using the MODULE_DEVICE_TABLE() macro. So the modules autoloading won’t work if the I2C device is registered using OF or legacy board files due missing alias information in the modules. The issue was found using Kieran …
May 17 2016
ASoC: nau8825: Export I2C module alias information
Author: Javier Martinez Canillas <javier@osg.samsung.com> The I2C driver has an i2c_device_id array but that information isn’t exported to the module using the MODULE_DEVICE_TABLE() macro. So the module autoloading won’t work if the I2C device is registered using OF or legacy board files due missing alias information in the module. The issue was found using Kieran …
