Category: Linux

ALSA: hda: Delete an unnecessary check before the function call “snd_info_free_entry”

Author: Markus Elfring <elfring@users.sourceforge.net> The snd_info_free_entry() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai — sound/pci/hda/patch_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff …

Continue reading

drm/msm/dsi: Delete an unnecessary check before the function call “dsi_destroy”

Author: Markus Elfring <elfring@users.sourceforge.net> The dsi_destroy() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Rob Clark — drivers/gpu/drm/msm/dsi/dsi.c | 4 +— 1 file changed, 1 insertion(+), 3 deletions(-)   diff …

Continue reading

ipmi: Delete an unnecessary check before the function call “cleanup_one_si”

Author: Markus Elfring <elfring@users.sourceforge.net> The cleanup_one_si() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Corey Minyard — drivers/char/ipmi/ipmi_si_intf.c | 4 +— 1 file changed, 1 insertion(+), 3 deletions(-)   diff …

Continue reading

tc1100-wmi: Delete an unnecessary check before the function call “kfree”

Author: Markus Elfring <elfring@users.sourceforge.net> The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Darren Hart — drivers/platform/x86/tc1100-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)   diff …

Continue reading

crypto: qat – Deletion of unnecessary checks before two function calls

Author: Markus Elfring <elfring@users.sourceforge.net> The functions kfree() and release_firmware() test whether their argument is NULL and then return immediately. Thus the test around the calls is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Herbert Xu — drivers/crypto/qat/qat_common/adf_accel_engine.c | 5 +—- drivers/crypto/qat/qat_common/adf_transport.c | 2 +- 2 files changed, …

Continue reading

eCryptfs: Delete a check before the function call “key_put”

Author: Markus Elfring <elfring@users.sourceforge.net> The key_put() function tests whether its argument is NULL and then returns immediately. Thus the test around this call might not be needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Tyler Hicks — fs/ecryptfs/crypto.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   …

Continue reading

f2fs crypto: delete an unnecessary check before the function call “key_put”

Author: Markus Elfring <elfring@users.sourceforge.net> The key_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Jaegeuk Kim — fs/f2fs/crypto_key.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-)   diff …

Continue reading

[media] ttpci: Replace memset with eth_zero_addr

Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use eth_zero_addr to assign the zero address to the given address array instead of memset when second argument is address of zero. Note that the 6 in the third argument of memset appears to represent an ethernet address size (ETH_ALEN). The Coccinelle semantic patch that makes this change is as follows: …

Continue reading

[media] pctv452e: Replace memset with eth_zero_addr

Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use eth_zero_addr to assign the zero address to the given address array instead of memset when second argument is address of zero. Note that the 6 in the third argument of memset appears to represent an ethernet address size (ETH_ALEN). The Coccinelle semantic patch that makes this change is as follows: …

Continue reading

Staging: rtl8192u: Replace memset with eth_zero_addr

Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use eth_zero_addr to assign the zero address to the given address array instead of memset when second argument is address of zero. Note that the 6 in the third argument of memset appears to represent an ethernet address size (ETH_ALEN). The Coccinelle semantic patch that makes this change is as follows: …

Continue reading