Category: Coccinelle

mfd: smsc-ece1099: Return directly after a function failure in smsc_i2c_probe()

Author: Markus Elfring <elfring@users.sourceforge.net> This issue was detected by using the Coccinelle software. Return directly if a call of the function “devm_regmap_init_i2c” or “regmap_write” failed. Delete the jump label “err” then. Signed-off-by: Markus Elfring Signed-off-by: Lee Jones — drivers/mfd/smsc-ece1099.c | 9 +++—— 1 file changed, 3 insertions(+), 6 deletions(-)   diff –git a/drivers/mfd/smsc-ece1099.c b/drivers/mfd/smsc-ece1099.c index …

Continue reading

mfd: dm355evm_msp: Return directly after a failed platform_device_alloc() in add_child()

Author: Markus Elfring <elfring@users.sourceforge.net> The platform_device_put() function was called in one case by the add_child() function during error handling even if the passed variable “pdev” contained a null pointer. Return directly in this case. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Lee Jones — drivers/mfd/dm355evm_msp.c | 7 ++—– 1 …

Continue reading

mfd: twl-core: Return directly after a failed platform_device_alloc() in add_numbered_child()

Author: Markus Elfring <elfring@users.sourceforge.net> The platform_device_put() function was called in one case by the add_numbered_child() function during error handling even if the passed variable “pdev” contained a null pointer. Return directly in this case. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Lee Jones — drivers/mfd/twl-core.c | 7 ++—– 1 …

Continue reading

pinctrl: sirf: atlas7: Add missing of_node_put

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> of_find_node_by_name does an of_node_get on its return value, so an of_node_put is needed on this value before the corresponding variable goes out of scope. The Coccinelle semantic patch used to make this change is as follows: @@ struct device_node *n; struct device_node *n1; statement S; identifier f; expression E; constant …

Continue reading

caif: Remove unneeded header file

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ – #include Signed-off-by: Amitoj Kaur Chawla Signed-off-by: David S. Miller — net/caif/chnl_net.c | 1 – 1 file changed, 1 deletion(-)   diff …

Continue reading

ASoC: wm8753: Remove unneeded header file

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ @ depends on includesmodule @ @@ – #include Signed-off-by: Amitoj Kaur Chawla Acked-by: Charles Keepax Signed-off-by: Mark Brown — sound/soc/codecs/wm8753.c | 1 – 1 file changed, 1 deletion(-)   …

Continue reading

i40e: Remove redundant memset

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Remove redundant call to memset before a call to memcpy. The Coccinelle semantic patch used to make this change is as follows: @@ expression e1,e2,e3,e4; @@ – memset(e1,e2,e3); memcpy(e1,e4,e3); Signed-off-by: Amitoj Kaur Chawla Tested-by: Andrew Bowers Signed-off-by: Jeff Kirsher — drivers/net/ethernet/intel/i40e/i40e_main.c | 1 – 1 file changed, 1 deletion(-)   …

Continue reading

dlm: Use kmemdup instead of kmalloc and memcpy

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Replace calls to kmalloc followed by a memcpy with a direct call to kmemdup. The Coccinelle semantic patch used to make this change is as follows: @@ expression from,to,size,flag; statement S; @@ – to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || …) S – memcpy(to, from, size); Signed-off-by: …

Continue reading

tipc: Use kmemdup instead of kmalloc and memcpy

Author: Amitoj Kaur Chawla <amitoj1606@gmail.com> Replace calls to kmalloc followed by a memcpy with a direct call to kmemdup. The Coccinelle semantic patch used to make this change is as follows: @@ expression from,to,size,flag; statement S; @@ – to = \(kmalloc\|kzalloc\)(size,flag); + to = kmemdup(from,size,flag); if (to==NULL || …) S – memcpy(to, from, size); Signed-off-by: …

Continue reading

ASoC: cs35l33: fix platform_no_drv_owner.cocci warnings

Author: kbuild test robot <lkp@intel.com> sound/soc/codecs/cs35l33.c:1301:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu Signed-off-by: Mark Brown — sound/soc/codecs/cs35l33.c | 1 – 1 file changed, 1 deletion(-)   diff –git a/sound/soc/codecs/cs35l33.c b/sound/soc/codecs/cs35l33.c index 841374a..55c1f75 100644 …

Continue reading

BtrLinux
Privacy Overview

This website uses cookies so that we can provide you with the best user experience possible. Cookie information is stored in your browser and performs functions such as recognising you when you return to our website and helping our team to understand which sections of the website you find most interesting and useful.