Quentin LAMBERT
Author's posts
Nov 23 2008
drivers/pci/hotplug: Add missing pci_dev_get
Author: Julia Lawall <julia@diku.dk> pci_get_slot does a pci_dev_get, so pci_dev_put needs to be called in an error case. An alterative would be to move the test_and_set_bit before the call to pci_get_slot. The problem was fixed using the following semantic patch. (http://www.emn.fr/x-info/coccinelle/) // @@ local idexpression *n; statement S1,S2; expression E,E1; expression *ptr != NULL; type …
Nov 23 2008
powerpc: Eliminate NULL test and memset after alloc_bootmem
Author: Julia Lawall <julia@diku.dk> As noted by Akinobu Mita in commit b1fceac2 (“x86: remove unnecessary memset and NULL check after alloc_bootmem()”), alloc_bootmem and related functions never return NULL and always return a zeroed region of memory. Thus a NULL test or memset after calls to these functions is unnecessary. This was fixed using the following …
Nov 20 2008
drivers/video/backlight/da903x.c: introduce missing kfree
Author: Julia Lawall <julia@diku.dk> Error handling code following a kzalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,l; position p1,p2; expression *ptr != NULL; @@ ( if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(…)) == NULL) S | x@p1 …
Nov 20 2008
drivers/video: bad error test before a dereference
Author: Julien Brunel <brunel@diku.dk> The error test that follows the call to backlight_device_register semms not to concern the right variable. A simplified version of the semantic match that finds this problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @def0@ expression x; position p0; @@ x@p0 = backlight_device_register(…) @protected@ expression def0.x,E; position def0.p0; position p; statement S; @@ …
Nov 18 2008
trace: introduce missing mutex_unlock()
Author: Vegard Nossum <vegard.nossum@gmail.com> Impact: fix tracing buffer mutex leak in case of allocation failure This error was spotted by this semantic patch: http://www.emn.fr/x-info/coccinelle/mut.html It looks correct as far as I can tell. Please review. Signed-off-by: Vegard Nossum Signed-off-by: Steven Rostedt Signed-off-by: Ingo Molnar — kernel/trace/ring_buffer.c | 1 + 1 file changed, 1 insertion(+) …
Nov 14 2008
ALSA: sound/pci/pcxhr/pcxhr.c: introduce missing kfree and pci_disable_device
Author: Julia Lawall <julia@diku.dk> Error handling code following a kzalloc should free the allocated data. The error handling code is adjusted to call pci_disable_device(pci); as well, as done later in the function The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,l; …
Nov 14 2008
tracing: kernel/trace/trace.c: introduce missing kfree()
Author: Julia Lawall <julia@diku.dk> Impact: fix memory leak Error handling code following a kzalloc should free the allocated data. The semantic match that finds the problem is as follows: (http://www.emn.fr/x-info/coccinelle/) // @r exists@ local idexpression x; statement S; expression E; identifier f,l; position p1,p2; expression *ptr != NULL; @@ ( if ((x@p1 = \(kmalloc\|kzalloc\|kcalloc\)(…)) == …
Nov 13 2008
crypto: md4 – Use ARRAY_SIZE
Author: Julia Lawall <julia@diku.dk> ARRAY_SIZE is more concise to use when the size of an array is divided by the size of its type or the size of its first element. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @i@ @@ #include @depends on i using “paren.iso”@ type T; T[] E; …
Nov 13 2008
V4L/DVB (9638): drivers/media: use ARRAY_SIZE
Author: Julia Lawall <julia@diku.dk> ARRAY_SIZE is more concise to use when the size of an array is divided by the size of its type or the size of its first element. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @i@ @@ @depends on i using “paren.iso”@ type T; T[] E; @@ …
Nov 09 2008
Staging: wlan-ng: p80211wext.c: use ARRAY_SIZE
Author: Julia Lawall <julia@diku.dk> ARRAY_SIZE is more concise to use when the size of an array is divided by the size of its type or the size of its first element. The semantic patch that makes this change is as follows: (http://www.emn.fr/x-info/coccinelle/) // @i@ @@ #include @depends on i using “paren.iso”@ type T; T[] E; …
