Quentin LAMBERT
Author's posts
Dec 03 2012
staging: line6: Use kmemdup rather than duplicating its implementation
Author: Laurent Navet <laurent.navet@gmail.com> staging: line6: driver.c The semantic patch that makes this output is available in scripts/coccinelle/api/memdup.cocci. Signed-off-by: Laurent Navet Signed-off-by: Greg Kroah-Hartman — drivers/staging/line6/driver.c | 5 ++— 1 file changed, 2 insertions(+), 3 deletions(-) diff –git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c index 1e4ce500..71c2a57 100644 — a/drivers/staging/line6/driver.c +++ b/drivers/staging/line6/driver.c @@ -307,14 +307,13 @@ int line6_version_request_async(struct usb_line6 …
Nov 29 2012
char/tpm: Use true and false for bools
Author: Peter Huewe <peterhuewe@gmx.de> Bool initializations should use true and false. Bool tests don’t need comparisons. Based on contributions from Joe Perches, Rusty Russell and Bruce W Allan. The semantic patch that makes this output is available in scripts/coccinelle/misc/boolinit.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Peter Huewe Signed-off-by: Kent Yoder — …
Nov 23 2012
UBI: replace memcpy with struct assignment
Author: Ezequiel Garcia <elezegarcia@gmail.com> This kind of memcpy() is error-prone. Its replacement with a struct assignment is prefered because it’s type-safe and much easier to read. Found by coccinelle. Hand patched and reviewed. Tested by compilation only. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier …
Nov 21 2012
[SCSI] qla2xxx: Fix coccinelle warnings in qla2x00_relogin.
Author: Saurav Kashyap <saurav.kashyap@qlogic.com> Reported-by: Fengguang Wu Signed-off-by: Giridhar Malavali Signed-off-by: Saurav Kashyap Signed-off-by: James Bottomley — drivers/scsi/qla2xxx/qla_os.c | 7 +++—- 1 file changed, 3 insertions(+), 4 deletions(-) diff –git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 0cdc6e2..132556b 100644 — a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -3720,10 +3720,9 @@ void qla2x00_relogin(struct scsi_qla_host *vha) if (fcport->flags & FCF_FCP2_DEVICE) opts |= BIT_1; …
Nov 08 2012
ARM: OMAP1: use BUG_ON where possible
Author: Sasha Levin <sasha.levin@oracle.com> Just use BUG_ON() instead of constructions such as: if (…) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ – if (e) BUG(); + BUG_ON(e); // Signed-off-by: Sasha Levin Signed-off-by: Tony Lindgren — arch/arm/mach-omap1/board-fsample.c | 3 +– arch/arm/mach-omap1/board-h2.c | …
Nov 08 2012
ARM: integrator: use BUG_ON where possible
Author: Sasha Levin <sasha.levin@oracle.com> Just use BUG_ON() instead of constructions such as: if (…) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ – if (e) BUG(); + BUG_ON(e); // Signed-off-by: Sasha Levin Acked-by: Arnd Bergmann Signed-off-by: Linus Walleij — arch/arm/mach-integrator/pci_v3.c | 9 …
Nov 08 2012
alpha: use BUG_ON where possible
Author: Sasha Levin <sasha.levin@oracle.com> Just use BUG_ON() instead of constructions such as: if (…) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ – if (e) BUG(); + BUG_ON(e); // Signed-off-by: Sasha Levin Signed-off-by: Jiri Kosina — arch/alpha/kernel/pci_iommu.c | 12 ++++——– 1 file …
Nov 03 2012
drivers/net/wireless/ath/ath6kl/hif.c: drop if around WARN_ON
Author: Julia Lawall <Julia.Lawall@lip6.fr> Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ – if (e) WARN_ON(1); + WARN_ON(e); // Signed-off-by: Julia Lawall Signed-off-by: Kalle Valo — drivers/net/wireless/ath/ath6kl/hif.c | 6 ++—- 1 file changed, …
Nov 03 2012
drivers/net/wireless/ath/ath6kl/hif.c: drop if around WARN_ON
Author: Julia Lawall <Julia.Lawall@lip6.fr> Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ – if (e) WARN_ON(1); + WARN_ON(e); // Signed-off-by: Julia Lawall Signed-off-by: John W. Linville — drivers/net/wireless/ath/ath6kl/hif.c | 6 ++—- 1 file …
Nov 03 2012
ext3: drop if around WARN_ON
Author: Julia Lawall <Julia.Lawall@lip6.fr> Just use WARN_ON rather than an if containing only WARN_ON(1). A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // @@ expression e; @@ – if (e) WARN_ON(1); + WARN_ON(e); // Signed-off-by: Julia Lawall Signed-off-by: Jan Kara — fs/ext3/inode.c | 3 +– 1 file changed, …