Quentin LAMBERT
Author's posts
Dec 18 2013
i40e: use assignment instead of memcpy
Author: Mitch Williams <mitch.a.williams@intel.com> These instances were found by coccinelle/spatch, and can use struct assignment instead of memcpy. Change-ID: Idc23c3599241bf8a658bda18c80417af3fbfee66 Signed-off-by: Mitch Williams Signed-off-by: Jesse Brandeburg Tested-by: Sibai Li Tested-by: Kavindya Deegala Signed-off-by: Jeff Kirsher — drivers/net/ethernet/intel/i40e/i40e_adminq.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_common.c | 3 +– drivers/net/ethernet/intel/i40e/i40e_hmc.c | 8 +++—– 3 files changed, 5 insertions(+), 8 deletions(-) …
Dec 16 2013
ASoC: axi-spdif: Use devm_ioremap_resource() instead of devm_request_and_ioremap()
Author: Fengguang Wu <fengguang.wu@intel.com> devm_request_and_ioremap() has been deprecated in favour of devm_ioremap_resource(). Fixes the following coccinelle warning: sound/soc/adi/axi-spdif.c:194:8-32: ERROR: deprecated devm_request_and_ioremap() API used on line 194 Generated by: coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Fengguang Wu Signed-off-by: Lars-Peter Clausen Signed-off-by: Mark Brown — sound/soc/adi/axi-spdif.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-) diff –git a/sound/soc/adi/axi-spdif.c b/sound/soc/adi/axi-spdif.c …
Dec 16 2013
ASoC: axi-spdif: Use devm_ioremap_resource() instead of devm_request_and_ioremap()
Author: Fengguang Wu <fengguang.wu@intel.com> devm_request_and_ioremap() has been deprecated in favour of devm_ioremap_resource(). Fixes the following coccinelle warning: sound/soc/adi/axi-i2s.c:195:8-32: ERROR: deprecated devm_request_and_ioremap() API used on line 195 Generated by: coccinelle/api/devm_ioremap_resource.cocci Signed-off-by: Fengguang Wu Signed-off-by: Lars-Peter Clausen Signed-off-by: Mark Brown — sound/soc/adi/axi-i2s.c | 6 +++— 1 file changed, 3 insertions(+), 3 deletions(-) diff –git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c …
Dec 11 2013
drm: use memdup_user() as a cleanup
Author: Dan Carpenter <dan.carpenter@oracle.com> drivers/gpu/drm/r128/r128_state.c:1014:10-17: WARNING opportunity for memdup_user /c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:1029:9-16: WARNING opportunity for memdup_user /c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:904:10-17: WARNING opportunity for memdup_user /c/kernel-tests/src/cocci/drivers/gpu/drm/r128/r128_state.c:914:9-16: WARNING opportunity for memdup_user Use memdup_user rather than duplicating its implementation This is a little bit restricted to reduce false positives Generated by: coccinelle/api/memdup_user.cocci CC: Daniel Vetter Signed-off-by: Dan Carpenter Signed-off-by: Daniel Vetter Signed-off-by: Dave …
Dec 09 2013
crytpo: ccp – fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/crypto/ccp/ccp-crypto-aes.c:344:1-7: Replace memcpy with struct assignment drivers/crypto/ccp/ccp-crypto-sha.c:398:1-7: Replace memcpy with struct assignment drivers/crypto/ccp/ccp-dev.c:578:2-3: Unneeded semicolon /c/kernel-tests/src/cocci/drivers/crypto/ccp/ccp-dev.c:565:2-3: Unneeded semicolon Generated by: coccinelle/misc/memcpy-assign.cocci CC: Tom Lendacky Signed-off-by: Fengguang Wu Signed-off-by: Herbert Xu — drivers/crypto/ccp/ccp-crypto-aes.c | 2 +- drivers/crypto/ccp/ccp-crypto-sha.c | 2 +- drivers/crypto/ccp/ccp-dev.c | 4 ++– 3 files changed, 4 insertions(+), 4 deletions(-) …
Dec 05 2013
USB: fix coccinelle warnings
Author: Fengguang Wu <fengguang.wu@intel.com> drivers/usb/host/ehci-mv.c:181:26-27: WARNING comparing pointer to 0, suggest !E /c/kernel-tests/src/cocci/drivers/usb/host/ehci-mv.c:181:26-27: WARNING comparing pointer to 0 Compare pointer-typed values to NULL rather than 0 Semantic patch information: This makes an effort to choose between !x and x == NULL. !x is used if it has previously been used with the function used to …
Nov 26 2013
tpm: Create a tpm_class_ops structure and use it in the drivers
Author: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> This replaces the static initialization of a tpm_vendor_specific structure in the drivers with the standard Linux idiom of providing a const structure of function pointers. Signed-off-by: Jason Gunthorpe Reviewed-by: Joel Schopp Reviewed-by: Ashley Lai [phuewe: did apply manually due to commit 191ffc6bde3 tpm/tpm_i2c_atmel: fix coccinelle warnings] Signed-off-by: Peter Huewe — drivers/char/tpm/tpm-interface.c …
Nov 26 2013
tpm: Pull all driver sysfs code into tpm-sysfs.c
Author: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> The tpm core now sets up and controls all sysfs attributes, instead of having each driver have a unique take on it. All drivers now now have a uniform set of attributes, and no sysfs related entry points are exported from the tpm core module. This also uses the new method …
Nov 21 2013
staging/lustre: remove CFS_MODULE_PARM
Author: Peng Tao <bergwolf@gmail.com> Patch generated by coccinelle: @generic_type@ declarer name CFS_MODULE_PARM; declarer name module_param; declarer name MODULE_PARM_DESC; expression E1, E2, E3, E4; type t; @@ -CFS_MODULE_PARM(E1, E2, t, E3, E4); +module_param(E1, t, E3); +MODULE_PARM_DESC(E1, E4); @charp@ expression E1, E2, E3, E4, E5; @@ -CFS_MODULE_PARM(E1, E2, E3, E4, E5); +module_param(E1, E3, E4); +MODULE_PARM_DESC(E1, E5); With …
Nov 13 2013
drivers/rtc/rtc-ds1307.c: change variable type to bool
Author: Peter Senna Tschudin <peter.senna@gmail.com> The variable want_irq is only assigned the values true and false. Change its type to bool. The simplified semantic patch that find this problem is as follows (http://coccinelle.lip6.fr/): @exists@ type T; identifier b; @@ – T + bool b = …; … when any b = \(true\|false\) Signed-off-by: Peter Senna …