Author's posts
Dec 30 2013
ath5k: use ether_addr_equal_64bits
Author: Julia Lawall <Julia.Lawall@lip6.fr> Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be used when each argument is an array within a structure that contains at least two bytes of data beyond the array. The structures involved are: ieee80211_mgmt defined in include/linux/ieee80211.h and ath_common defined in drivers/net/wireless/ath/ath.h This was done using Coccinelle (http://coccinelle.lip6.fr/). Signed-off-by: Julia …
Dec 30 2013
rt2x00: use ether_addr_equal_64bits
Author: Julia Lawall <Julia.Lawall@lip6.fr> Ether_addr_equal_64bits is more efficient than ether_addr_equal, and can be used when each argument is an array within a structure that contains at least two bytes of data beyond the array. The structures involved are: ieee80211_bar defined in include/linux/ieee80211.h and rt2x00_bar_list_entry defined in drivers/net/wireless/rt2x00/rt2x00.h. This was done using Coccinelle (http://coccinelle.lip6.fr/). Signed-off-by: Julia …
Dec 30 2013
thermal: exynos: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret …
Dec 30 2013
RDMA/nes: Fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret …
Dec 30 2013
fujitsu-laptop: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> These functions mix the use of result and error. In acpi_fujitsu_add, result does not seem useful; it would seem reasonable to propagate the return value of acpi_bus_update_power in an error case. On the other hand, in the case of acpi_fujitsu_hotkey_add, there is an initialization of result that can lead to what …
Dec 30 2013
[media] e4000: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret …
Dec 30 2013
RDMA/amso1100: Fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret …
Dec 30 2013
hamradio: 6pack: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret …
Dec 30 2013
HID: sony: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Currently the return variable ret is always 0. Set it to other values in error cases, as used in the direct return. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | …
Dec 30 2013
usb: gadget: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Set the return variable to an error code as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret …