Quentin LAMBERT
Author's posts
May 17 2014
video: delete unneeded call to platform_get_drvdata
Author: Julia Lawall <Julia.Lawall@lip6.fr> Platform_get_drvdata is an accessor function, and has no purpose if its result is not used. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; type T; @@ – T x = platform_get_drvdata(…); … when != x // Signed-off-by: Julia Lawall Signed-off-by: Tomi Valkeinen — drivers/video/fbdev/bf54x-lq043fb.c …
May 16 2014
staging/rtl8192u: Put EXPORT_SYMBOL just after the exported function
Author: Benoit Taine <benoit.taine@lip6.fr> Export of symbols statement must be placed right after the definition to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // @ r @ identifier f; @@ – EXPORT_SYMBOL(f); @@ identifier r.f; @@ …
May 15 2014
vti6: delete unneeded call to netdev_priv
Author: Julia Lawall <Julia.Lawall@lip6.fr> Netdev_priv is an accessor function, and has no purpose if its result is not used. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ local idexpression x; @@ -x = netdev_priv(…); … when != x // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller …
May 15 2014
ip_tunnel: delete unneeded call to netdev_priv
Author: Julia Lawall <Julia.Lawall@lip6.fr> Netdev_priv is an accessor function, and has no purpose if its result is not used. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ local idexpression x; @@ -x = netdev_priv(…); … when != x // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller …
May 15 2014
net/ariadne: delete unneeded call to netdev_priv
Author: Julia Lawall <Julia.Lawall@lip6.fr> Netdev_priv is an accessor function, and has no purpose if its result is not used. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ local idexpression x; @@ -x = netdev_priv(…); … when != x // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller …
May 15 2014
drivers/net/wan: delete unneeded call to netdev_priv
Author: Julia Lawall <Julia.Lawall@lip6.fr> Netdev_priv is an accessor function, and has no purpose if its result is not used. A simplified version of the semantic match that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ local idexpression x; @@ -x = netdev_priv(…); … when != x // Signed-off-by: Julia Lawall Signed-off-by: David S. Miller …
May 14 2014
drm/i915: use dev_priv directly in i915_driver_unload
Author: Daniel Vetter <daniel.vetter@ffwll.ch> Noticed while playing with coccinelle. Reviewed-by: Damien Lespiau Signed-off-by: Daniel Vetter — drivers/gpu/drm/i915/i915_dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c index d02c8de..46f1dec 100644 — a/drivers/gpu/drm/i915/i915_dma.c +++ b/drivers/gpu/drm/i915/i915_dma.c @@ -1867,7 +1867,7 @@ int i915_driver_unload(struct drm_device *dev) kmem_cache_destroy(dev_priv->slab); pci_dev_put(dev_priv->bridge_dev); – kfree(dev->dev_private); + kfree(dev_priv); …
May 11 2014
net: get rid of SET_ETHTOOL_OPS
Author: Wilfried Klaebe <w-lkml@lebenslange-mailadresse.de> net: get rid of SET_ETHTOOL_OPS Dave Miller mentioned he’d like to see SET_ETHTOOL_OPS gone. This does that. Mostly done via coccinelle script: @@ struct ethtool_ops *ops; struct net_device *dev; @@ – SET_ETHTOOL_OPS(dev, ops); + dev->ethtool_ops = ops; Compile tested only, but I’d seriously wonder if this broke anything. Suggested-by: Dave Miller …
May 10 2014
hwrng: n2-drv – Introduce the use of the managed version of kzalloc
Author: Himangi Saraogi <himangi774@gmail.com> This patch moves data allocated using kzalloc to managed data allocated using devm_kzalloc and cleans now unnecessary kfrees in probe and remove functions. The NULL assignment to np->units is removed as there is no interaction between this field and sun4v_hvapi_unregister. Also, the labels out_free_units and out_free are removed as they are …
May 08 2014
ASoC: rt5645: fix coccinelle warnings
Author: Oder Chiou <oder_chiou@realtek.com> Return statements in functions returning bool should use true/false instead of 1/0. Signed-off-by: Oder Chiou Signed-off-by: Mark Brown — sound/soc/codecs/rt5645.c | 8 ++++—- 1 file changed, 4 insertions(+), 4 deletions(-) diff –git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c index 30410eb..68923ec 100644 — a/sound/soc/codecs/rt5645.c +++ b/sound/soc/codecs/rt5645.c @@ -242,9 +242,9 @@ static bool rt5645_volatile_register(struct device *dev, …