Quentin LAMBERT
Author's posts
Sep 08 2014
crypto: memzero_explicit – make sure to clear out sensitive data
Author: Daniel Borkmann <dborkman@redhat.com> Recently, in commit 13aa93c70e71 (“random: add and use memzero_explicit() for clearing data”), we have found that GCC may optimize some memset() cases away when it detects a stack variable is not being used anymore and going out of scope. This can happen, for example, in cases when we are clearing out …
Sep 07 2014
PCI: Remove assignment from “if” conditions
Author: Quentin Lambert <lambert.quentin@gmail.com> The following Coccinelle semantic patch was used to find and correct cases of assignments in “if” conditions: @@ expression var, expr; statement S; @@ + var = expr; if( – (var = expr) + var ) S Signed-off-by: Quentin Lambert Signed-off-by: Bjorn Helgaas — drivers/pci/hotplug/acpi_pcihp.c | 3 ++- drivers/pci/hotplug/cpci_hotplug_core.c | 9 …
Sep 07 2014
staging: lustre: obdclass: expand the GOTO macro
Author: Julia Lawall <Julia.Lawall@lip6.fr> The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier lbl; identifier rc; constant c; @@ – GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ – GOTO(lbl,rc); + rc; + goto lbl; // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/obdclass/acl.c | 27 +++– drivers/staging/lustre/lustre/obdclass/capa.c …
Sep 07 2014
staging: lustre: obdclass: expand the GOTO macro + break
Author: Julia Lawall <Julia.Lawall@lip6.fr> The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier lbl,rc,f; constant c; @@ – GOTO(lbl,\(rc\|rc->f\|c\)); – break; + goto lbl; @@ identifier lbl; expression rc; @@ – GOTO(lbl,rc); – break; + rc; + goto lbl; // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/obdclass/obd_config.c | 16 …
Sep 07 2014
staging: lustre: obdclass: expand double GOTO macros
Author: Julia Lawall <Julia.Lawall@lip6.fr> The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier lbl; @@ if (…) GOTO(lbl,…); +else GOTO(lbl,…); @@ identifier lbl; expression e,e1,e2; @@ if (e) – GOTO(lbl,e1); -else GOTO(lbl,e2); + e1; +else e2; +goto lbl; @@ identifier lbl1,lbl2; expression e,e1,e2; @@ + e1=e2; if (e) – GOTO(lbl1,e1=e2); …
Sep 07 2014
staging: lustre: lvfs: expand the GOTO macro
Author: Julia Lawall <Julia.Lawall@lip6.fr> The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier lbl; identifier rc; constant c; @@ – GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ – GOTO(lbl,rc); + rc; + goto lbl; // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/lvfs/lvfs_linux.c | 12 ++++++++—- 1 …
Sep 07 2014
staging: lustre: libcfs: expand the GOTO macro
Author: Julia Lawall <Julia.Lawall@lip6.fr> The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier lbl; identifier rc; constant c; @@ – GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ – GOTO(lbl,rc); + rc; + goto lbl; // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/libcfs/module.c | 3 ++- drivers/staging/lustre/lustre/libcfs/upcall_cache.c …
Sep 07 2014
staging: lustre: ptlrpc: expand the GOTO macro
Author: Julia Lawall <Julia.Lawall@lip6.fr> The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier lbl; identifier rc; constant c; @@ – GOTO(lbl,\(rc\|c\)); + goto lbl; @@ identifier lbl; expression rc; @@ – GOTO(lbl,rc); + rc; + goto lbl; // Signed-off-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/lustre/lustre/ptlrpc/client.c | 32 +++++—- drivers/staging/lustre/lustre/ptlrpc/connection.c …
Sep 03 2014
[media] s5p-tv: Simplify the return logic
Author: Mauro Carvalho Chehab <m.chehab@samsung.com> Make sure pm_runtime_* calls does not use unnecessary IS_ERR_VALUE(). Reported by scripts/coccinelle/api/pm_runtime.cocci script. Signed-off-by: Mauro Carvalho Chehab — drivers/media/platform/s5p-tv/hdmi_drv.c | 2 +- drivers/media/platform/s5p-tv/sdo_drv.c | 2 +- drivers/media/platform/s5p-tv/sii9234_drv.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff –git a/drivers/media/platform/s5p-tv/hdmi_drv.c b/drivers/media/platform/s5p-tv/hdmi_drv.c index 754740f..37c8bd6 100644 — a/drivers/media/platform/s5p-tv/hdmi_drv.c +++ b/drivers/media/platform/s5p-tv/hdmi_drv.c @@ …
Sep 03 2014
[media] vivid-vid-out: use memdup_user()
Author: Mauro Carvalho Chehab <m.chehab@samsung.com> Instead of allocating and coping from __user, do it using one atomic call. That makes the code simpler. Found by coccinelle. Acked-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab — drivers/media/platform/vivid/vivid-vid-out.c | 10 +++——- 1 file changed, 3 insertions(+), 7 deletions(-) diff –git a/drivers/media/platform/vivid/vivid-vid-out.c b/drivers/media/platform/vivid/vivid-vid-out.c index c983461..8ed9f6d 100644 — a/drivers/media/platform/vivid/vivid-vid-out.c …