Quentin LAMBERT
Author's posts
Nov 21 2014
usb: gadget: function: delete an unnecessary check before rndis_add_hdr()
Author: Markus Elfring <elfring@users.sourceforge.net> The rndis_add_hdr() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Felipe Balbi — drivers/usb/gadget/function/f_rndis.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Nov 21 2014
tty: Deletion of unnecessary checks before two function calls
Author: Markus Elfring <elfring@users.sourceforge.net> The functions put_device() and tty_kref_put() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman — drivers/tty/tty_io.c | 6 ++—- drivers/tty/tty_port.c | 3 +– 2 files changed, …
Nov 21 2014
tty-hvsi_lib: Deletion of an unnecessary check before the function call “tty_kref_put”
Author: Markus Elfring <elfring@users.sourceforge.net> The tty_kref_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Greg Kroah-Hartman — drivers/tty/hvc/hvsi_lib.c | 3 +– 1 file changed, 1 insertion(+), 2 deletions(-) diff …
Nov 21 2014
target: Deletion of unnecessary checks before the function call “module_put”
Author: Markus Elfring <elfring@users.sourceforge.net> The module_put() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Nicholas Bellinger — drivers/target/iscsi/iscsi_target_transport.c | 3 +– drivers/target/target_core_hba.c | 6 ++—- 2 files changed, 3 insertions(+), …
Nov 20 2014
host: ehci-w90x900: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Nov 20 2014
serial: icom: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Nov 20 2014
usb: dwc3: keystone: fix error return code
Author: Julia Lawall <Julia.Lawall@lip6.fr> Return a negative error code on failure. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier ret; expression e1,e2; @@ ( if (\(ret < 0\|ret != 0\)) { ... return ret; } | ret = 0 ) ... when != ret = …
Nov 20 2014
net: brcm80211: Deletion of unnecessary checks before two function calls
Author: Markus Elfring <elfring@users.sourceforge.net> The functions brcmu_pkt_buf_free_skb() and release_firmware() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Acked-by: Arend van Spriel Signed-off-by: John W. Linville — drivers/net/wireless/brcm80211/brcmfmac/firmware.c | 3 +– drivers/net/wireless/brcm80211/brcmfmac/msgbuf.c | …
Nov 20 2014
net: USB: Deletion of unnecessary checks before the function call “kfree”
Author: Markus Elfring <elfring@users.sourceforge.net> The kfree() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: David S. Miller — drivers/net/usb/asix_devices.c | 3 +– drivers/net/usb/hso.c | 3 +– 2 files changed, 2 …
Nov 20 2014
net: Xilinx: Deletion of unnecessary checks before two function calls
Author: Markus Elfring <elfring@users.sourceforge.net> The functions kfree() and of_node_put() test whether their argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Reviewed-by: Soren Brinkmann Signed-off-by: David S. Miller — drivers/net/ethernet/xilinx/ll_temac_main.c | 3 +– drivers/net/ethernet/xilinx/xilinx_emaclite.c | 3 …