Quentin LAMBERT
Author's posts
Mar 03 2015
staging: rtl8192u: replace memset(x,0,ETH_ALEN) by eth_zero_addr(x)
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The replacement was done by the following coccinelle script: @header@ @@ #include @eth_zero_addr@ expression e; @@ -memset(e,0,ETH_ALEN); +eth_zero_addr(e); @eth_broadcast_addr@ identifier e; @@ -memset(e,\(0xff\|0xFF\|255\),ETH_ALEN); +eth_broadcast_addr(e); @linux_header depends on !header && (eth_zero_addr || eth_broadcast_addr) @ …
Mar 03 2015
staging: rtl8192e: replace memset(x,0,ETH_ALEN) by eth_zero_addr(x)
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The replacement was done by the following coccinelle script: @header@ @@ #include @eth_zero_addr@ expression e; @@ -memset(e,0,ETH_ALEN); +eth_zero_addr(e); @eth_broadcast_addr@ identifier e; @@ -memset(e,\(0xff\|0xFF\|255\),ETH_ALEN); +eth_broadcast_addr(e); @linux_header depends on !header && (eth_zero_addr || eth_broadcast_addr) @ …
Mar 03 2015
staging: rtl8192e: replace memset(x,0,ETH_ALEN) by eth_zero_addr(x)
Author: Aya Mahfouz <mahfouz.saif.elyazal@gmail.com> eth_zero_addr() is a wrapper function for memset if 0 is going to be assigned to a mac address. The replacement was done by the following coccinelle script: @header@ @@ #include @eth_zero_addr@ expression e; @@ -memset(e,0,ETH_ALEN); +eth_zero_addr(e); @eth_broadcast_addr@ identifier e; @@ -memset(e,\(0xff\|0xFF\|255\),ETH_ALEN); +eth_broadcast_addr(e); @linux_header depends on !header && (eth_zero_addr || eth_broadcast_addr) @ …
Mar 03 2015
staging: comedi: Remove if condition.
Author: Navya Sri Nizamkari <navyasri.tech@gmail.com> This patch removes a if condition which has a semicolon after it. As the conditional check is redundant, the comment before it is also changed. The following coccinelle script was used to detect the pattern of a semicolon after if. @r1@ position p; @@ if (…);@p @script:python@ p0
Mar 02 2015
staging: lustre: lustre: libcfs: Replaced printk() with pr_err() and pr_cont()
Author: Tina Johnson <tinajohnson.1234@gmail.com> The following checkpatch warning was fixed: Prefer [subsystem eg: netdev]_err([subsystem]dev with the help of Coccinelle. pr_cont() was used to replace those printk statements which followed a printk that did not end with a ‘\n’. The following semantic patch was used to replace printk() with pr_err(): @a@ expression e; @@ printk(e,…); @script:python …
Mar 02 2015
staging: lustre: lustre: libcfs: Replaced printk() with pr_err()
Author: Tina Johnson <tinajohnson.1234@gmail.com> The following checkpatch warning was fixed: Prefer [subsystem eg: netdev]_err([subsystem]dev with the help of Coccinelle. The following semantic patch was used: @a@ expression e; @@ printk(e,…); @script:python b@ e
Mar 02 2015
power/smb347-charger.c: set IRQF_ONESHOT flag to ensure IRQ request
Author: Valentin Rothberg <Valentin.Rothberg@lip6.fr> Since commit 1c6c69525b40eb76de8adf039409722015927dc3 (“genirq: Reject bogus threaded irq requests”) threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request may fail. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci Signed-off-by: Valentin Rothberg Signed-off-by: Sebastian Reichel — drivers/power/smb347-charger.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff –git a/drivers/power/smb347-charger.c …
Mar 01 2015
Staging: rtl8192e: Remove unneeded brackets.
Author: Vatika Harlalka <vatikaharlalka@gmail.com> These were detected with this Coccinelle script: @@ identifier f1, f2, f3; constant c; @@ f1 = ( – (f2 f3) + f2 >> f3 | – (f2 c) + f2 >> c ) Signed-off-by: Vatika Harlalka Acked-by: Julia Lawall Signed-off-by: Greg Kroah-Hartman — drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 12 ++++++—— 1 file changed, …
Feb 28 2015
Staging: rtl8712: Use del_timer
Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use timer API function del_timer instead of driver specific function _cancel_timer_ex as it is a standard way for deactivating a timer. This is done using Coccinelle and semantic patch used for this is as follows: @@ expression x; @@ – _cancel_timer_ex (&x); + del_timer (&x); Signed-off-by: Vaishali Thakkar Signed-off-by: Greg Kroah-Hartman …
Feb 28 2015
md/cluster: Communication Framework: fix semicolon.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> drivers/md/md-cluster.c:328:2-3: Unneeded semicolon Removes unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Signed-off-by: Fengguang Wu Signed-off-by: NeilBrown — drivers/md/md-cluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff –git a/drivers/md/md-cluster.c b/drivers/md/md-cluster.c index 5062bd1..ae8bb54 100644 — a/drivers/md/md-cluster.c +++ b/drivers/md/md-cluster.c @@ -419,7 +419,7 @@ static void process_recvd_msg(struct mddev *mddev, struct cluster_msg *msg) …