Quentin LAMBERT
Author's posts
Jun 10 2015
[media] s5p-tv: fix wait_event_timeout return handling
Author: Nicholas Mc Guire <hofrat@osadl.org> event API conformance testing with coccinelle spatches are being used to locate API usage inconsistencies this triggert with: ./drivers/media/platform/s5p-tv/mixer_reg.c:364 incorrect check for negative return Return type of wait_event_timeout is signed long not int and the return type is >=0 always thus the negative check is unnecessary. An appropriately named variable …
Jun 10 2015
[media] ddbridge: fix wait_event_timeout return handling
Author: Nicholas Mc Guire <hofrat@osadl.org> API conformance testing for completions with coccinelle spatches are being used to locate API usage inconsistencies: ./drivers/media/pci/ddbridge/ddbridge-core.c:89 incorrect check for negative return Return type of wait_event_timeout is signed long not int and the return type is >=0 always thus the negative check is unnecessary.. As stat is used here exclusively …
Jun 10 2015
atm: idt77105: Use setup_timer
Author: Vaishali Thakkar <vthakkar1994@gmail.com> Use the timer API function setup_timer instead of structure field assignments to initialize a timer. A simplified version of the Coccinelle semantic patch that performs this transformation is as follows: @change@ expression e1, e2, a; @@ -init_timer(&e1); +setup_timer(&e1, a, 0UL); … when != a = e2 -e1.function = a; Signed-off-by: Vaishali …
Jun 09 2015
Staging: vt6655: Remove unnecessary equality checks in rxtx.c
Author: Harisangam Sharvari <sharisan@visteon.com> The unnecessary equality checks for bool variable are removed in rxtx.c. These changes were detected with the help of coccinelle tool Signed-off-by: Harisangam Sharvari Signed-off-by: Greg Kroah-Hartman — drivers/staging/vt6655/rxtx.c | 8 ++++—- 1 file changed, 4 insertions(+), 4 deletions(-) diff –git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c index 33c4aa4..534338c 100644 — a/drivers/staging/vt6655/rxtx.c +++ b/drivers/staging/vt6655/rxtx.c …
Jun 08 2015
atm: use msecs_to_jiffies for conversions
Author: Nicholas Mc Guire <hofrat@osadl.org> API compliance scanning with coccinelle flagged: ./drivers/atm/iphase.c:2621:4-20: WARNING: timeout (50) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent which does not seem intended. Fixed up by converting the constant to jiffies with msecs_to_jiffies() As this driver was introduced in the early 2.3 series it …
Jun 07 2015
[media] gscpa_m5602: use msecs_to_jiffies for conversions
Author: Nicholas Mc Guire <hofrat@osadl.org> API compliance scanning with coccinelle flagged: ./drivers/media/usb/gspca/m5602/m5602_s5k83a.c:180:9-25: WARNING: timeout (100) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent which makes little sense in a polling loop for the cameras rotation state. Fixed up by converting the constant to jiffies with msecs_to_jiffies() Signed-off-by: Nicholas Mc …
Jun 07 2015
wan: dscc4: use msecs_to_jiffies for conversions
Author: Nicholas Mc Guire <hofrat@osadl.org> API compliance scanning with coccinelle flagged: ./drivers/net/wan/dscc4.c:1036:1-33: WARNING: timeout (10) seems HZ dependent ./drivers/net/wan/dscc4.c:554:2-34: WARNING: timeout (10) seems HZ dependent ./drivers/net/wan/dscc4.c:599:2-34: WARNING: timeout (10) seems HZ dependent Numeric constants passed to schedule_timeout_*() make the effective timeout HZ dependent which does not seem to be the intent here. Fixed up by …
Jun 06 2015
cosa: use msecs_to_jiffies for conversions
Author: Nicholas Mc Guire <hofrat@osadl.org> API compliance scanning with coccinelle flagged: ./drivers/net/wan/cosa.c:520:2-18: WARNING: timeout (30) seems HZ dependent Numeric constants passed to schedule_timeout() make the effective timeout HZ dependent which makes little sense in a device probe. Fixed up by converting the constant to jiffies with msecs_to_jiffies() Signed-off-by: Nicholas Mc Guire Signed-off-by: David S. Miller …
Jun 04 2015
ASoC: zx: fix platform_no_drv_owner.cocci warnings
Author: kbuild test robot <fengguang.wu@intel.com> sound/soc/zte/zx296702-i2s.c:428:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Signed-off-by: Fengguang Wu Signed-off-by: Mark Brown — sound/soc/zte/zx296702-i2s.c | 1 – 1 file changed, 1 deletion(-) diff –git a/sound/soc/zte/zx296702-i2s.c b/sound/soc/zte/zx296702-i2s.c index 472fde3..98d96e1 100644 …
Jun 04 2015
video: fbdev: vesafb: use arch_phys_wc_add()
Author: Luis R. Rodriguez <mcgrof@suse.com> This driver uses the same area for MTRR as for the ioremap_wc(), if anything it just uses a smaller size in case MTRR reservation fails. ioremap_wc() API is already used to take advantage of architecture write-combining when available. Convert the driver from using the x86 specific MTRR code to the …