ARM: integrator: use BUG_ON where possible

Author: Sasha Levin <sasha.levin@oracle.com>

Just use BUG_ON() instead of constructions such as:

	if (...)
		BUG()

A simplified version of the semantic patch that makes this transformation
is as follows: (http://coccinelle.lip6.fr/)

// 
@@
expression e;
@@
- if (e) BUG();
+ BUG_ON(e);
// 

Signed-off-by: Sasha Levin 
Acked-by: Arnd Bergmann 
Signed-off-by: Linus Walleij

---
 arch/arm/mach-integrator/pci_v3.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)
 
diff --git a/arch/arm/mach-integrator/pci_v3.c b/arch/arm/mach-integrator/pci_v3.c
index 000edcd..be50e79 100644
--- a/arch/arm/mach-integrator/pci_v3.c
+++ b/arch/arm/mach-integrator/pci_v3.c
@@ -191,12 +191,9 @@ static void __iomem *v3_open_config_window(struct pci_bus *bus,
 	/*
 	 * Trap out illegal values
 	 */
-	if (offset > 255)
-		BUG();
-	if (busnr > 255)
-		BUG();
-	if (devfn > 255)
-		BUG();
+	BUG_ON(offset > 255);
+	BUG_ON(busnr > 255);
+	BUG_ON(devfn > 255);
 
 	if (busnr == 0) {
 		int slot = PCI_SLOT(devfn);

ARM: integrator: use BUG_ON where possible

qlambert

Archives

Posts by Subject